Merge pull request #257 from Thiht/fix/lua

fix: convert request to map[string]interface{} before passing it to the global Lua context to handle query params and headers correctly

Author: gwleclerc

server/templates/lua.go

@@ -5,7 +5,7 @@ import (
 	"time"
 
 	"github.com/Thiht/smocker/server/types"
-	json "github.com/layeh/gopher-json"
+	goJson "github.com/layeh/gopher-json"
 	log "github.com/sirupsen/logrus"
 	"github.com/yuin/gluamapper"
 	lua "github.com/yuin/gopher-lua"
@@ -51,7 +51,12 @@ func (*luaEngine) Execute(request types.Request, script string) (*types.MockResp
 		return nil, fmt.Errorf("failed to sandbox Lua environment: %w", err)
 	}
 
-	luaState.SetGlobal("request", luar.New(luaState, request))
+	m, err := StructToMSI(request)
+	if err != nil {
+		return nil, fmt.Errorf("failed to convert request as map[string]any: %w", err)
+	}
+
+	luaState.SetGlobal("request", luar.New(luaState, m))
 	if err := luaState.DoString(script); err != nil {
 		log.WithError(err).Error("Failed to execute Lua script")
 		return nil, fmt.Errorf("failed to execute Lua script: %w", err)
@@ -61,7 +66,7 @@ func (*luaEngine) Execute(request types.Request, script string) (*types.MockResp
 	body := luaResult.RawGetString("body")
 	if body.Type() == lua.LTTable {
 		// FIXME: this should depend on the Content-Type of the luaResult
-		b, _ := json.Encode(body)
+		b, _ := goJson.Encode(body)
 		luaResult.RawSetString("body", lua.LString(string(b)))
 	}
 

server/templates/utils.go

@@ -0,0 +1,16 @@
+package templates
+
+import "encoding/json"
+
+func StructToMSI(s interface{}) (map[string]interface{}, error) {
+	bytes, err := json.Marshal(s)
+	if err != nil {
+		return nil, err
+	}
+	msi := map[string]interface{}{}
+	err = json.Unmarshal(bytes, &msi)
+	if err != nil {
+		return nil, err
+	}
+	return msi, nil
+}

tests/data/dynamic_mock_list.yml

@@ -21,9 +21,14 @@
   dynamic_response:
     engine: lua
     script: >
+      local name;
+      if request.query_params ~= nil then
+        name = request.query_params.name[1]
+      end
       return {
         body = {
-          message = "request path "..request.path
+          message = "request path "..request.path,
+          name = name,
         },
         headers = {
           ["Content-Type"] = "application/json"

tests/features/use_mocks.yml

@@ -185,10 +185,11 @@ testcases:
 
       - type: http
         method: GET
-        url: http://localhost:8080/test2
+        url: http://localhost:8080/test2?name=test2
         assertions:
           - result.statuscode ShouldEqual 200
           - result.bodyjson.message ShouldEqual "request path /test2"
+          - result.bodyjson.name ShouldEqual test2
 
       - type: http
         method: GET