Rename literal_string_with_formatting_arg into literal_string_with_formatting_args

Author: GuillaumeGomez

CHANGELOG.md

@@ -5639,7 +5639,7 @@ Released 2018-09-13
 [`lines_filter_map_ok`]: https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
 [`linkedlist`]: https://rust-lang.github.io/rust-clippy/master/index.html#linkedlist
 [`lint_groups_priority`]: https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
-[`literal_string_with_formatting_arg`]: https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_arg
+[`literal_string_with_formatting_args`]: https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args
 [`little_endian_bytes`]: https://rust-lang.github.io/rust-clippy/master/index.html#little_endian_bytes
 [`logic_bug`]: https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
 [`lossy_float_literal`]: https://rust-lang.github.io/rust-clippy/master/index.html#lossy_float_literal

clippy_dev/src/lib.rs

@@ -7,7 +7,7 @@
     unused_lifetimes,
     unused_qualifications
 )]
-#![allow(clippy::missing_panics_doc, clippy::literal_string_with_formatting_arg)]
+#![allow(clippy::missing_panics_doc)]
 
 // The `rustc_driver` crate seems to be required in order to use the `rust_lexer` crate.
 #[allow(unused_extern_crates)]

clippy_lints/src/declared_lints.rs

@@ -276,7 +276,7 @@ pub static LINTS: &[&crate::LintInfo] = &[
     crate::literal_representation::MISTYPED_LITERAL_SUFFIXES_INFO,
     crate::literal_representation::UNREADABLE_LITERAL_INFO,
     crate::literal_representation::UNUSUAL_BYTE_GROUPINGS_INFO,
-    crate::literal_string_with_formatting_arg::LITERAL_STRING_WITH_FORMATTING_ARG_INFO,
+    crate::literal_string_with_formatting_args::LITERAL_STRING_WITH_FORMATTING_ARGS_INFO,
     crate::loops::EMPTY_LOOP_INFO,
     crate::loops::EXPLICIT_COUNTER_LOOP_INFO,
     crate::loops::EXPLICIT_INTO_ITER_LOOP_INFO,

clippy_lints/src/lib.rs

@@ -18,7 +18,7 @@
     clippy::must_use_candidate,
     rustc::diagnostic_outside_of_impl,
     rustc::untranslatable_diagnostic,
-    clippy::literal_string_with_formatting_arg
+    clippy::literal_string_with_formatting_args
 )]
 #![warn(
     trivial_casts,
@@ -198,7 +198,7 @@ mod let_with_type_underscore;
 mod lifetimes;
 mod lines_filter_map_ok;
 mod literal_representation;
-mod literal_string_with_formatting_arg;
+mod literal_string_with_formatting_args;
 mod loops;
 mod macro_metavars_in_unsafe;
 mod macro_use;
@@ -962,7 +962,7 @@ pub fn register_lints(store: &mut rustc_lint::LintStore, conf: &'static Conf) {
     store.register_late_pass(move |_| Box::new(manual_div_ceil::ManualDivCeil::new(conf)));
     store.register_late_pass(|_| Box::new(manual_is_power_of_two::ManualIsPowerOfTwo));
     store.register_late_pass(|_| Box::new(non_zero_suggestions::NonZeroSuggestions));
-    store.register_early_pass(|| Box::new(literal_string_with_formatting_arg::LiteralStringWithFormattingArg));
+    store.register_early_pass(|| Box::new(literal_string_with_formatting_args::LiteralStringWithFormattingArg));
     store.register_late_pass(move |_| Box::new(unused_trait_names::UnusedTraitNames::new(conf)));
     store.register_late_pass(|_| Box::new(manual_ignore_case_cmp::ManualIgnoreCaseCmp));
     store.register_late_pass(|_| Box::new(unnecessary_literal_bound::UnnecessaryLiteralBound));

clippy_lints/src/literal_string_with_formatting_arg.rs renamed to clippy_lints/src/literal_string_with_formatting_args.rs

@@ -28,12 +28,12 @@ declare_clippy_lint! {
     /// x.expect(&format!("{y:?}"));
     /// ```
     #[clippy::version = "1.83.0"]
-    pub LITERAL_STRING_WITH_FORMATTING_ARG,
+    pub LITERAL_STRING_WITH_FORMATTING_ARGS,
     suspicious,
     "Checks if string literals have formatting arguments"
 }
 
-declare_lint_pass!(LiteralStringWithFormattingArg => [LITERAL_STRING_WITH_FORMATTING_ARG]);
+declare_lint_pass!(LiteralStringWithFormattingArg => [LITERAL_STRING_WITH_FORMATTING_ARGS]);
 
 impl EarlyLintPass for LiteralStringWithFormattingArg {
     fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
@@ -94,15 +94,15 @@ impl EarlyLintPass for LiteralStringWithFormattingArg {
                 1 => {
                     span_lint(
                         cx,
-                        LITERAL_STRING_WITH_FORMATTING_ARG,
+                        LITERAL_STRING_WITH_FORMATTING_ARGS,
                         spans,
                         "this looks like a formatting argument but it is not part of a formatting macro",
                     );
                 },
                 _ => {
                     span_lint(
                         cx,
-                        LITERAL_STRING_WITH_FORMATTING_ARG,
+                        LITERAL_STRING_WITH_FORMATTING_ARGS,
                         spans,
                         "these look like formatting arguments but are not part of a formatting macro",
                     );

tests/ui-toml/large_include_file/large_include_file.rs

@@ -1,5 +1,5 @@
 #![warn(clippy::large_include_file)]
-#![allow(clippy::literal_string_with_formatting_arg)]
+#![allow(clippy::literal_string_with_formatting_args)]
 
 // Good
 const GOOD_INCLUDE_BYTES: &[u8; 68] = include_bytes!("../../ui/author.rs");

tests/ui/auxiliary/proc_macro_derive.rs

@@ -2,7 +2,7 @@
 #![allow(incomplete_features)]
 #![allow(clippy::field_reassign_with_default)]
 #![allow(clippy::eq_op)]
-#![allow(clippy::literal_string_with_formatting_arg)]
+#![allow(clippy::literal_string_with_formatting_args)]
 
 extern crate proc_macro;
 

tests/ui/format.fixed

@@ -7,7 +7,7 @@
     clippy::uninlined_format_args,
     clippy::needless_raw_string_hashes,
     clippy::useless_vec,
-    clippy::literal_string_with_formatting_arg
+    clippy::literal_string_with_formatting_args
 )]
 
 struct Foo(pub String);

tests/ui/format.rs

@@ -7,7 +7,7 @@
     clippy::uninlined_format_args,
     clippy::needless_raw_string_hashes,
     clippy::useless_vec,
-    clippy::literal_string_with_formatting_arg
+    clippy::literal_string_with_formatting_args
 )]
 
 struct Foo(pub String);

tests/ui/literal_string_with_formatting_arg.rs

@@ -1,20 +1,20 @@
-#![warn(clippy::literal_string_with_formatting_arg)]
+#![warn(clippy::literal_string_with_formatting_args)]
 #![allow(clippy::unnecessary_literal_unwrap)]
 
 fn main() {
     let x: Option<usize> = None;
     let y = "hello";
-    x.expect("{y} {}"); //~ literal_string_with_formatting_arg
-    x.expect(" {y} bla"); //~ literal_string_with_formatting_arg
-    x.expect("{:?}"); //~ literal_string_with_formatting_arg
-    x.expect("{y:?}"); //~ literal_string_with_formatting_arg
-    x.expect(" {y:?} {y:?} "); //~ literal_string_with_formatting_arg
-    x.expect(" {y:..} {y:?} "); //~ literal_string_with_formatting_arg
-    x.expect(r"{y:?}  {y:?} "); //~ literal_string_with_formatting_arg
-    x.expect(r"{y:?} y:?}"); //~ literal_string_with_formatting_arg
-    x.expect(r##" {y:?} {y:?} "##); //~ literal_string_with_formatting_arg
+    x.expect("{y} {}"); //~ literal_string_with_formatting_args
+    x.expect(" {y} bla"); //~ literal_string_with_formatting_args
+    x.expect("{:?}"); //~ literal_string_with_formatting_args
+    x.expect("{y:?}"); //~ literal_string_with_formatting_args
+    x.expect(" {y:?} {y:?} "); //~ literal_string_with_formatting_args
+    x.expect(" {y:..} {y:?} "); //~ literal_string_with_formatting_args
+    x.expect(r"{y:?}  {y:?} "); //~ literal_string_with_formatting_args
+    x.expect(r"{y:?} y:?}"); //~ literal_string_with_formatting_args
+    x.expect(r##" {y:?} {y:?} "##); //~ literal_string_with_formatting_args
     // Ensure that it doesn't try to go in the middle of a unicode character.
-    x.expect("———{:?}"); //~ literal_string_with_formatting_arg
+    x.expect("———{:?}"); //~ literal_string_with_formatting_args
 
     // Should not lint!
     format!("{y:?}");