smoldot ExternalOffchainIndexSet doesn't set offchain storage.

[Wsteth]

smoldot version: 0.19.3

Hi there,
I use chopsticks to test some offchain things.
the runtime code use offchain_index.set, but it doesn't work.
I found the problem occurs here.

smoldot/lib/src/executor/runtime_call.rs

Lines 1750 to 1759 in 37482d9

	host::HostVm::ExternalOffchainIndexSet(req) => {
	self.pending_storage_changes
	.offchain_storage_changes
	.insert(
	req.key().as_ref().to_vec(),
	req.value().map(|v| v.as_ref().to_vec()),
	);
	self.vm = req.resume();
	}

It seems there is nothing done with add pending_storage_changes, and when I remove pending_storage_changes, I can get the storage value.

[tomaka]

Hi,

I haven't touched this code is several years, but I believe that this is intentional.
The "offchain index" API is actually unrelated to the "offchain storage" API. They're two separate things.
I don't remember, however, what the differences are, and I can't really find information on the Internet, but since you're presumably working on this you might be more familiar with it.

[Wsteth]

Hi,

I haven't touched this code is several years, but I believe that this is intentional. The "offchain index" API is actually unrelated to the "offchain storage" API. They're two separate things. I don't remember, however, what the differences are, and I can't really find information on the Internet, but since you're presumably working on this you might be more familiar with it.

Hi sir, I've create a PR #2119 to fix this problem, please check and review it.