Don't explicitly panic or block when avoidable #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
Aug 24, 2025
Co-authored-by: Taiki Endo <[email protected]>
taiki-e
approved these changes
Aug 24, 2025
taiki-e
approved these changes
Aug 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate has a number of unwraps and asserts that could be avoided and result in a bit of extra, potentially unnecessary, codegen, and its use of a std RwLock/Mutex does result in unnecessary blocking.
This PR converts any explicitly done (read: non-allocator) panics into handled errors, as well as moves stealing to not block when it cannot obtain a read lock on the queues.