Skip to content

Commit 71d82f0

Browse files
committed
fix clang-scan complaints
Signed-off-by: Stephan Mueller <smueller@chronox.de>
1 parent 72e55cb commit 71d82f0

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

apps/src/sbsign.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@ static int pkcs7_ver_message_sbsign(struct pkcs7_generator_opts *opts,
287287
goto out;
288288
} else if (ret == -ENOKEY) {
289289
printf("No signer found - skipping signature verification as requested\n");
290-
ret = 0;
291290
}
292291
}
293292

apps/src/sbvarsign.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,15 @@ static uint32_t parse_attrs(const char *attrs_str)
167167
if (attr == attr_invalid) {
168168
fprintf(stderr, "Invalid attribute string %s\n",
169169
attr_str);
170-
return attr_invalid;
170+
attrs_val = attr_invalid;
171+
goto out;
171172
}
172173

173174
attrs_val |= attr;
174175
}
175176

177+
out:
178+
free(str);
176179
return attrs_val;
177180
}
178181

@@ -381,7 +384,6 @@ verify_auth_descriptor(struct pkcs7_generator_opts *opts,
381384
goto out;
382385
} else if (ret == -ENOKEY) {
383386
printf("No signer found - skipping signature verification as requested\n");
384-
ret = 0;
385387
}
386388
}
387389

0 commit comments

Comments
 (0)