initialization: provide lc_init in all cases

If the leancrypto library is compiled statically, the constructors are
not invoked. Instead, the consuming application must invoke lc_init.

This is also applied to test cases where each test case now invokes
lc_init if leancrypto is compiled statically.

Signed-off-by: Stephan Mueller <smueller@chronox.de>

Author: smuellerDD

addon/generate_header.sh

@@ -147,6 +147,12 @@ header='/*
  * variables is desired, proper accessor functions are available. This implies
  * that changes to the data structures in newer versions of the library are not
  * considered as API changes!
+ *
+ * \note The leancrypto library performs an automated initialization during
+ * its startup using constructors. If your execution environment does not offer
+ * such constructors, or the library is compiled statically, the function
+ * `lc_init` must be called by the consuming application before any leancrypto
+ * API is invoked.
  */
 '
 

internal/api/initialization.h

@@ -26,15 +26,12 @@
 extern "C" {
 #endif
 
-/* Enable these declarations only if there is no automatic constructor */
-#ifndef LC_CONSTRUCTOR_AUTOMATIC_AVAILABLE
 void ascon_fastest_impl(void);
 void sha256_fastest_impl(void);
 void sha512_fastest_impl(void);
 void sha3_fastest_impl(void);
 void aes_fastest_impl(void);
 void kyber_riscv_rvv_selector(void);
-#endif /* LC_CONSTRUCTOR_AUTOMATIC_AVAILABLE */
 
 #ifdef __cplusplus
 }

internal/api/visibility.h

@@ -69,7 +69,15 @@
 
 #define LC_INIT_FUNCTION(ret, symbol, param...) DSO_PUBLIC ret symbol(param)
 
+#ifdef LC_STATIC
+#define LC_TEST_FUNC(ret, symbol, param...)                                    \
+	int lc_init(unsigned int flags);                                       \
+	static ret __ ## symbol(param);                                        \
+	ret symbol(param) { lc_init(0); return __ ## symbol(argc, argv); }     \
+	static ret __ ## symbol(param)
+#else
 #define LC_TEST_FUNC(ret, symbol, param...) ret symbol(param)
+#endif
 
 #pragma GCC diagnostic pop
 
@@ -85,11 +93,9 @@
 	void _func(void)
 #else /* LC_EFI */
 
-#define LC_CONSTRUCTOR_AUTOMATIC_AVAILABLE
-
 #define LC_CONSTRUCTOR(_func)                                                  \
-	static void __attribute__((constructor)) _func(void);                  \
-	static void _func(void)
+	void __attribute__((constructor)) _func(void);                         \
+	void _func(void)
 #endif /* LC_EFI */
 
 #endif /* LINUX_KERNEL */

internal/src/meson.build

@@ -7,7 +7,8 @@ internal_src += files([
 ])
 
 src_fips += files([
-	'fips_integrity_check.c'
+	'fips_integrity_check.c',
+	'leancrypto_init.c',
 ])
 
 if get_option('efi').disabled()
@@ -17,10 +18,6 @@ if get_option('efi').disabled()
 	src_fips += files([
 		'status.c'
 	])
-else
-	internal_src += files([
-		'leancrypto_init.c',
-	])
 endif
 
 if get_option('efi').enabled()

meson.build

@@ -232,6 +232,13 @@ if get_option('pkcs7_debug').enabled()
 	add_global_arguments([ '-DLC_PKCS7_DEBUG' ], language: 'c')
 endif
 
+# Whether to build the shared library alongside the static library
+build_shared = (get_option('default_library') != 'static' and
+		get_option('efi').disabled())
+if (not build_shared)
+	add_global_arguments([ '-DLC_STATIC' ], language: 'c')
+endif
+
 # 64 bit time to not suffer from Y2038 problem
 add_global_arguments([ '-D_TIME_BITS=64' ], language: 'c')
 
@@ -631,10 +638,6 @@ leancrypto_support_libs_fips = [ ]
 # External libraries leancrypto should link to
 leancrypto_link = [ ]
 
-# Whether to build the shared library alongside the static library
-build_shared = (get_option('default_library') != 'static' and
-		get_option('efi').disabled())
-
 foreach n : subdirs
 	subdir(n)
 endforeach