fix clang-scan complaints

Signed-off-by: Stephan Mueller <smueller@chronox.de>

Author: smuellerDD

drng/tests/cshake_drng_tester.c

@@ -117,7 +117,7 @@ static int cshake_drng_selftest(struct lc_rng_ctx *cshake_ctx)
 
 static int cshake_drng_test(void)
 {
-	struct lc_rng_ctx *cshake_ctx_heap;
+	struct lc_rng_ctx *cshake_ctx_heap = NULL;
 	int ret;
 	LC_CSHAKE256_DRNG_CTX_ON_STACK(cshake_ctx);
 

drng/tests/kmac_drng_tester.c

@@ -114,7 +114,7 @@ static int kmac_drng_selftest(struct lc_rng_ctx *kmac_ctx)
 
 static int kmac_test(void)
 {
-	struct lc_rng_ctx *kmac_ctx_heap;
+	struct lc_rng_ctx *kmac_ctx_heap = NULL;
 	int ret;
 	LC_KMAC256_DRNG_CTX_ON_STACK(kmac_ctx);
 

drng/tests/xdrbg128_tester.c

@@ -178,7 +178,7 @@ static int xdrbg128_drng_selftest(struct lc_rng_ctx *xdrbg128_ctx)
 
 static int xdrbg128_drng_test(void)
 {
-	struct lc_rng_ctx *xdrbg128_ctx_heap;
+	struct lc_rng_ctx *xdrbg128_ctx_heap = NULL;
 	int ret;
 	LC_XDRBG128_DRNG_CTX_ON_STACK(xdrbg128_ctx);
 

drng/tests/xdrbg256_tester.c

@@ -200,7 +200,7 @@ static int xdrbg256_drng_selftest(struct lc_rng_ctx *xdrbg256_ctx)
 
 static int xdrbg256_drng_test(void)
 {
-	struct lc_rng_ctx *xdrbg256_ctx_heap;
+	struct lc_rng_ctx *xdrbg256_ctx_heap = NULL;
 	int ret;
 	LC_XDRBG256_DRNG_CTX_ON_STACK(xdrbg256_ctx);
 

kdf/tests/kdf_ctr_tester.c

@@ -112,6 +112,8 @@ static int kdf_ctr_tester(void)
 		  "CTR KDF failed\n");
 
 	ret = lc_compare(act, exp, sizeof(exp), "CTR KDF SHA-256");
+	if (ret)
+		goto out;
 
 	CKINT_LOG(lc_rng_seed(ctr_kdf_rng, key, sizeof(key), NULL, 0),
 		  "Counter KDF extract stack failed\n");
@@ -120,13 +122,17 @@ static int kdf_ctr_tester(void)
 				  sizeof(act)),
 		  "Counter KDF expand stack failed\n");
 
-	ret += lc_compare(act, exp, sizeof(exp), "CTR KDF SHA-256 RNG");
+	ret = lc_compare(act, exp, sizeof(exp), "CTR KDF SHA-256 RNG");
+	if (ret)
+		goto out;
 
 	CKINT_LOG(lc_kdf_ctr(lc_sha256, key2, sizeof(key2), label2,
 			     sizeof(label2), act2, sizeof(act2)),
 		  "CTR KDF failed\n");
 
-	ret += lc_compare(act2, exp2, sizeof(exp2), "CTR KDF SHA-256");
+	ret = lc_compare(act2, exp2, sizeof(exp2), "CTR KDF SHA-256");
+	if (ret)
+		goto out;
 
 	CKINT_LOG(lc_kdf_ctr_rng_alloc(&ctr_kdf_rng_heap, lc_sha256),
 		  "Allocation of heap CTR KDF RNG context failed: %d\n", ret);
@@ -138,7 +144,7 @@ static int kdf_ctr_tester(void)
 				  act2, sizeof(act2)),
 		  "Counter KDF expand stack failed\n");
 
-	ret += lc_compare(act2, exp2, sizeof(exp2), "CTR KDF SHA-256 RNG");
+	ret = lc_compare(act2, exp2, sizeof(exp2), "CTR KDF SHA-256 RNG");
 
 out:
 	lc_rng_zero_free(ctr_kdf_rng_heap);