utils: add emit_result_and_signal() with log_pass/fail/skip wrappers

Introduce emit_result_and_signal() to standardize writing test results to
.res files and emitting LAVA-compatible result signals to stderr. This
function ensures compatibility with both direct test execution and
suite-based runs using run-test.sh.

Adds:
- emit_result_and_signal(TESTCASE, RESULT)
- log_pass_and_emit()
- log_fail_and_emit()
- log_skip_and_emit()

This avoids direct 'echo > .res' in run.sh, enables proper result accumulation,
and ensures LAVA signals are robust even under dmesg log flooding.

Signed-off-by: Srikanth Muppandam <[email protected]>

Author: smuppand

Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh

@@ -41,52 +41,48 @@ log_info "=== Test Initialization ==="
 
 # Get the firmware output and find the position of adsp
 log_info "Checking for firmware"
-firmware_output=$(cat /sys/class/remoteproc/remoteproc*/firmware)
+firmware_output=$(cat /sys/class/remoteproc/remoteproc*/firmware 2>/dev/null)
 adsp_position=$(echo "$firmware_output" | grep -n "adsp" | cut -d: -f1)
 
-# Adjust the position to match the remoteproc numbering (starting from 0)
-remoteproc_number=$((adsp_position - 1))
+if [ -z "$adsp_position" ]; then
+    log_skip_and_emit "$TESTNAME"
+    exit 0
+fi
 
-# Construct the remoteproc path based on the adsp position
+remoteproc_number=$((adsp_position - 1))
 remoteproc_path="/sys/class/remoteproc/remoteproc${remoteproc_number}"
 log_info "Remoteproc node is $remoteproc_path"
-# Execute command 1 and check if the output is "running"
-state1=$(cat ${remoteproc_path}/state)
 
+# Check if already running
+state1=$(cat "${remoteproc_path}/state" 2>/dev/null)
 if [ "$state1" != "running" ]; then
-    log_fail "$TESTNAME : Test Failed"
-    echo "$TESTNAME FAIL" > "$test_path/$TESTNAME.res"
+    log_fail_and_emit "$TESTNAME"
     exit 1
 fi
 
-# Execute command 2 (no output expected)
 log_info "Stopping remoteproc"
-echo stop > ${remoteproc_path}/state
+echo stop > "${remoteproc_path}/state"
 
-# Execute command 3 and check if the output is "offline"
-state3=$(cat ${remoteproc_path}/state)
+state3=$(cat "${remoteproc_path}/state" 2>/dev/null)
 if [ "$state3" != "offline" ]; then
     log_fail "adsp stop failed"
-    echo "$TESTNAME FAIL" > "$test_path/$TESTNAME.res"
+    log_fail_and_emit "$TESTNAME"
     exit 1
 else
     log_pass "adsp stop successful"
 fi
+
 log_info "Restarting remoteproc"
-# Execute command 4 (no output expected)
-echo start > ${remoteproc_path}/state
+echo start > "${remoteproc_path}/state"
 
-# Execute command 5 and check if the output is "running"
-state5=$(cat ${remoteproc_path}/state)
+state5=$(cat "${remoteproc_path}/state" 2>/dev/null)
 if [ "$state5" != "running" ]; then
     log_fail "adsp start failed"
-    echo "$TESTNAME FAIL" > "$res_file" 
+    log_fail_and_emit "$TESTNAME"
     exit 1
 fi
 
-# If all checks pass, print "PASS"
-echo "adsp PASS"
 log_pass "adsp PASS"
-echo "$TESTNAME PASS" > "$res_file"
+log_pass_and_emit "$TESTNAME"
 log_info "-------------------Completed $TESTNAME Testcase----------------------------"
 exit 0

Runner/utils/functestlib.sh

@@ -16,6 +16,49 @@ log_error() { log "ERROR" "$@"; }
 log_skip()  { log "SKIP"  "$@"; }
 log_warn()  { log "WARN"  "$@"; }
 
+# Detect whether test is run as part of suite (run-test.sh)
+is_suite_run() {
+    # shellcheck disable=SC2009
+    ps -o comm= -p "$PPID" | grep -q "run-test.sh"
+}
+
+emit_result_and_signal() (
+    TESTCASE="$1"
+    RESULT="$2"
+
+    res_file="./${TESTCASE}.res"
+
+    # Overwrite only if running standalone and file doesn't exist
+    if ! is_suite_run && [ ! -f "$res_file" ]; then
+        : > "$res_file"
+    fi
+
+    echo "$TESTCASE $RESULT" >> "$res_file"
+
+    echo "" >&2
+    echo "<LAVA_SIGNAL_TESTCASE TEST_CASE_ID=${TESTCASE} RESULT=${RESULT}>" >&2
+    echo "" >&2
+    sleep 0.1
+)
+
+log_pass_and_emit() {
+    TESTCASE="$1"
+    log_pass "$TESTCASE PASS"
+    emit_result_and_signal "$TESTCASE" "PASS"
+}
+
+log_fail_and_emit() {
+    TESTCASE="$1"
+    log_fail "$TESTCASE FAIL"
+    emit_result_and_signal "$TESTCASE" "FAIL"
+}
+
+log_skip_and_emit() {
+    TESTCASE="$1"
+    log_skip "$TESTCASE SKIP"
+    emit_result_and_signal "$TESTCASE" "SKIP"
+}
+
 # --- Kernel Log Collection ---
 get_kernel_log() {
     if command -v journalctl >/dev/null 2>&1; then
@@ -133,19 +176,19 @@ unload_kernel_module() {
 check_dependencies() {
     missing=0
     missing_cmds=""
+    testname="${TESTNAME:-UnknownTest}"
+
     for cmd in "$@"; do
         if ! command -v "$cmd" >/dev/null 2>&1; then
             log_warn "Required command '$cmd' not found in PATH."
             missing=1
             missing_cmds="$missing_cmds $cmd"
         fi
     done
+
     if [ "$missing" -ne 0 ]; then
-        testname="${TESTNAME:-}"
-        log_skip "${testname:-UnknownTest} SKIP: missing dependencies:$missing_cmds"
-        if [ -n "$testname" ]; then
-            echo "$testname SKIP" > "./$testname.res"
-        fi
+        log_skip "${testname} SKIP: missing dependencies:$missing_cmds"
+        log_skip_and_emit "$testname"
         exit 0
     fi
 }