fix(slurm): handle integer slurm_account values from YAML parsing

Snakemake's YAML parser automatically converts numeric-looking strings
(e.g. "123456789") to integers when populating job.resources. This
caused account.lower() in test_account() to fail since int has no
lower() method.

Convert slurm_account and account values to strings before use in
re.split() and shlex.quote() calls.

Fixes the issue where users specifying slurm_account as a numeric
string in their YAML profile would get an AttributeError.

Author: andchamorro

snakemake_executor_plugin_slurm/__init__.py

@@ -1590,7 +1590,7 @@ def get_account_arg(self, job: JobExecutorInterface):
             # split the account upon ',' and whitespace, to allow
             # multiple accounts being given
             accounts = [
-                a for a in re.split(r"[,\s]+", job.resources.slurm_account) if a
+                a for a in re.split(r"[,\s]+", str(job.resources.slurm_account)) if a
             ]
             for account in accounts:
                 # here, we check whether the given or guessed account is valid
@@ -1602,15 +1602,15 @@ def get_account_arg(self, job: JobExecutorInterface):
             # contain build-in shell commands - see issue #354
             for account in accounts:
                 test_account(account, self.logger)
-                yield f" -A {shlex.quote(account)}"
+                yield f" -A {shlex.quote(str(account))}"
         else:
             if self._fallback_account_arg is None:
                 self.logger.warning("No SLURM account given, trying to guess.")
                 account = get_account(self.logger)
                 if account:
                     self.logger.warning(f"Guessed SLURM account: {account}")
                     test_account(f"{account}", self.logger)
-                    self._fallback_account_arg = f" -A {shlex.quote(account)}"
+                    self._fallback_account_arg = f" -A {shlex.quote(str(account))}"
                 else:
                     self.logger.warning(
                         "Unable to guess SLURM account. Trying to proceed without."

tests/test_account.py

@@ -0,0 +1,83 @@
+"""Unit tests for get_account_arg() method."""
+
+from types import SimpleNamespace
+from unittest.mock import MagicMock, patch
+
+from snakemake_executor_plugin_slurm import Executor
+
+
+class _Resources(dict):
+    """Dict-like resources with attribute access for known keys only."""
+
+    def __getattr__(self, name):
+        try:
+            return self[name]
+        except KeyError as e:
+            raise AttributeError(name) from e
+
+
+def _make_mock_job(rule_name="myrule", name=None, wildcards=None, jobid=1, is_group=False, **resources):
+    """Return a minimal mock job compatible with get_account_arg."""
+    mock_resources = _Resources(resources)
+
+    mock_rule = MagicMock()
+    mock_rule.name = rule_name
+
+    job = MagicMock()
+    job.resources = mock_resources
+    job.rule = mock_rule
+    job.name = name if name is not None else rule_name
+    job.wildcards = wildcards if wildcards is not None else {}
+    job.is_group.return_value = is_group
+    job.threads = resources.get("threads", 1)
+    job.jobid = jobid
+    return job
+
+
+class TestGetAccountArg:
+    """Tests for get_account_arg() method handling string and integer accounts."""
+
+    def _make_executor_stub(self):
+        """Return a minimal Executor stub."""
+        executor = Executor.__new__(Executor)
+        executor.logger = MagicMock()
+        executor._fallback_account_arg = None
+        return executor
+
+    @patch("snakemake_executor_plugin_slurm.get_account")
+    @patch("snakemake_executor_plugin_slurm.test_account")
+    def test_string_account(self, mock_test_account, mock_get_account, tmp_path):
+        """String account values work correctly."""
+        executor = self._make_executor_stub()
+        job = _make_mock_job(slurm_account="123456789")
+        result = next(executor.get_account_arg(job))
+        assert result == " -A 123456789"
+        mock_test_account.assert_called_with("123456789", executor.logger)
+
+    @patch("snakemake_executor_plugin_slurm.get_account")
+    @patch("snakemake_executor_plugin_slurm.test_account")
+    def test_integer_account(self, mock_test_account, mock_get_account, tmp_path):
+        """Integer account values (from YAML parsing) work correctly."""
+        executor = self._make_executor_stub()
+        job = _make_mock_job(slurm_account=123456789)
+        result = next(executor.get_account_arg(job))
+        assert result == " -A 123456789"
+        mock_test_account.assert_called_with("123456789", executor.logger)
+
+    @patch("snakemake_executor_plugin_slurm.get_account")
+    @patch("snakemake_executor_plugin_slurm.test_account")
+    def test_multiple_accounts_string(self, mock_test_account, mock_get_account, tmp_path):
+        """Multiple string accounts work correctly."""
+        executor = self._make_executor_stub()
+        job = _make_mock_job(slurm_account="acc1,acc2 acc3")
+        results = list(executor.get_account_arg(job))
+        assert results == [" -A acc1", " -A acc2", " -A acc3"]
+
+    @patch("snakemake_executor_plugin_slurm.get_account")
+    @patch("snakemake_executor_plugin_slurm.test_account")
+    def test_multiple_accounts_integer(self, mock_test_account, mock_get_account, tmp_path):
+        """Multiple integer accounts work correctly."""
+        executor = self._make_executor_stub()
+        job = _make_mock_job(slurm_account=123)
+        results = list(executor.get_account_arg(job))
+        assert results == [" -A 123"]