refactor: avoid recursive calls (#1001)

Author: wa0x6e

src/graphql/operations/options.ts

@@ -16,17 +16,18 @@ async function loadOptions() {
 }
 
 async function run() {
-  try {
-    log.info('[options] Start options refresh');
-    await loadOptions();
-    log.info(`[options] ${options.length} options reloaded`);
-    log.info('[options] End options refresh');
-  } catch (e: any) {
-    capture(e);
-    log.error(`[options] failed to refresh options, ${JSON.stringify(e)}`);
+  while (true) {
+    try {
+      log.info('[options] Start options refresh');
+      await loadOptions();
+      log.info(`[options] ${options.length} options reloaded`);
+      log.info('[options] End options refresh');
+    } catch (e: any) {
+      capture(e);
+      log.error(`[options] failed to refresh options, ${JSON.stringify(e)}`);
+    }
+    await snapshot.utils.sleep(RUN_INTERVAL);
   }
-  await snapshot.utils.sleep(RUN_INTERVAL);
-  run();
 }
 
 run();

src/helpers/spaces.ts

@@ -323,19 +323,19 @@ export async function getSpace(id: string) {
 }
 
 export default async function run() {
-  try {
-    log.info('[spaces] Start spaces refresh');
-
-    await loadSpaces();
-    await loadSpacesMetrics();
-
-    sortSpaces();
-    log.info('[spaces] End spaces refresh');
-  } catch (e: any) {
-    capture(e);
-    log.error(`[spaces] failed to load spaces, ${JSON.stringify(e)}`);
+  while (true) {
+    try {
+      log.info('[spaces] Start spaces refresh');
+
+      await loadSpaces();
+      await loadSpacesMetrics();
+
+      sortSpaces();
+      log.info('[spaces] End spaces refresh');
+    } catch (e: any) {
+      capture(e);
+      log.error(`[spaces] failed to load spaces, ${JSON.stringify(e)}`);
+    }
+    await snapshot.utils.sleep(RUN_INTERVAL);
   }
-  await snapshot.utils.sleep(RUN_INTERVAL);
-
-  run();
 }

src/helpers/strategies.ts

@@ -7,6 +7,7 @@ import { spaces } from './spaces';
 export let strategies: any[] = [];
 export let strategiesObj: any = {};
 
+const RUN_INTERVAL = 60e3;
 const scoreApiURL: URL = new URL(
   process.env.SCORE_API_URL ?? 'https://score.snapshot.org'
 );
@@ -56,19 +57,22 @@ async function loadStrategies() {
 }
 
 async function run() {
-  try {
-    await loadStrategies();
-    consecutiveFailsCount = 0;
-  } catch (e: any) {
-    consecutiveFailsCount++;
+  while (true) {
+    try {
+      log.info('[strategies] Start strategies refresh');
+      await loadStrategies();
+      consecutiveFailsCount = 0;
+      log.info('[strategies] End strategies refresh');
+    } catch (e: any) {
+      consecutiveFailsCount++;
 
-    if (consecutiveFailsCount >= 3) {
-      capture(e);
+      if (consecutiveFailsCount >= 3) {
+        capture(e);
+      }
+      log.error(`[strategies] failed to load ${JSON.stringify(e)}`);
     }
-    log.error(`[strategies] failed to load ${JSON.stringify(e)}`);
+    await snapshot.utils.sleep(RUN_INTERVAL);
   }
-  await snapshot.utils.sleep(60e3);
-  run();
 }
 
 run();