feat: add support for new skin logo in space settings (#498)

* fix: improve skin update code

* feat: add suppprt for logo in space skins

* test: fix tests

* fix: fix column order

* fix: allow skinParams only for turbo spaces

* fix: rename params to skinSettings to follow hub convention

* fix: save hex code when saving skin color

* fix: fix wrong invalid column update

Author: wa0x6e

src/helpers/actions.ts

@@ -66,15 +66,17 @@ export async function addOrUpdateSkin(id: string, skinSettings: Record<string, s
       SET ?
       ON DUPLICATE KEY UPDATE
         ${COLORS.map(color => `${color} = ?`).join(',')},
-        theme = COALESCE(VALUES(theme), theme)
+        theme = COALESCE(VALUES(theme), ?),
+        logo = ?
     `,
     [
       {
         id,
         ...skinSettings
       },
       ...COLORS.map(color => skinSettings[color]),
-      skinSettings.theme
+      skinSettings.theme,
+      skinSettings.logo
     ]
   );
 }

test/integration/helpers/actions.test.ts

@@ -200,7 +200,8 @@ describe('helpers/actions', () => {
         heading_color: '#ffffff',
         primary_color: '#ffffff',
         header_color: null,
-        theme: 'light'
+        theme: 'light',
+        logo: null
       });
     });
 
@@ -236,7 +237,8 @@ describe('helpers/actions', () => {
         heading_color: null,
         primary_color: null,
         header_color: null,
-        theme: 'light'
+        theme: 'light',
+        logo: null
       });
 
       await addOrUpdateSkin(testId, { theme: 'dark' });
@@ -251,7 +253,8 @@ describe('helpers/actions', () => {
         heading_color: null,
         primary_color: null,
         header_color: null,
-        theme: 'dark'
+        theme: 'dark',
+        logo: null
       });
     });
   });

test/schema.sql

@@ -204,6 +204,7 @@ CREATE TABLE skins (
   primary_color VARCHAR(7) DEFAULT NULL,
   header_color VARCHAR(7) DEFAULT NULL,
   theme VARCHAR(5) NOT NULL DEFAULT 'light',
+  logo VARCHAR(256) DEFAULT NULL,
   PRIMARY KEY (id)
 );