fix: use getter to avoid reference invalidation

Author: wa0x6e

src/helpers/spaceValidation.ts

@@ -1,6 +1,6 @@
 import snapshot from '@snapshot-labs/snapshot.js';
 import log from './log';
-import { strategies } from './strategies';
+import { getStrategies } from './strategies';
 
 const DEFAULT_SNAPSHOT_ENV: string = 'testnet';
 
@@ -67,7 +67,7 @@ export async function validateSpaceSettings(
   }
 
   for (const id of strategiesIds) {
-    const strategy = strategies[id];
+    const strategy = getStrategies()[id];
 
     if (!strategy) {
       return Promise.reject(`strategy "${id}" is not a valid strategy`);

src/helpers/strategies.ts

@@ -18,7 +18,7 @@ const URI = new URL(
 
 let consecutiveFailsCount = 0;
 let shouldStop = false;
-export let strategies: Record<Strategy['id'], Strategy> = {};
+let strategies: Record<Strategy['id'], Strategy> = {};
 
 async function loadStrategies() {
   const res = await snapshot.utils.getJSON(URI);
@@ -33,13 +33,18 @@ async function loadStrategies() {
     throw error;
   }
 
-  const strat = Object.values(res).map((strategy: any) => ({
+  const strategiesList = Object.values(res).map((strategy: any) => ({
     id: strategy.key,
     override: strategy.dependOnOtherAddress || false,
     disabled: strategy.disabled || false
   }));
 
-  strategies = Object.fromEntries(strat.map(strategy => [strategy.id, strategy]));
+  strategies = Object.fromEntries(strategiesList.map(strategy => [strategy.id, strategy]));
+}
+
+// Using a getter to avoid potential reference initialization issues
+export function getStrategies(): Record<Strategy['id'], Strategy> {
+  return strategies;
 }
 
 export async function initialize() {

test/integration/ingestor.test.ts

@@ -113,12 +113,12 @@ jest.mock('@snapshot-labs/pineapple', () => {
 });
 
 jest.mock('../../src/helpers/strategies', () => ({
-  strategies: {
+  getStrategies: jest.fn(() => ({
     'erc20-balance-of': { id: 'erc20-balance-of', override: false, disabled: false },
     'contract-call': { id: 'contract-call', override: true, disabled: false },
     delegation: { id: 'delegation', override: false, disabled: false },
     whitelist: { id: 'whitelist', override: false, disabled: false }
-  },
+  })),
   initialize: jest.fn().mockResolvedValue(undefined),
   run: jest.fn(),
   stop: jest.fn()

test/unit/helpers/spaceValidation.test.ts

@@ -9,7 +9,7 @@ const mockStrategies: Record<string, any> = {
 };
 
 jest.mock('../../../src/helpers/strategies', () => ({
-  strategies: mockStrategies
+  getStrategies: jest.fn(() => mockStrategies)
 }));
 
 // Mock the log module to avoid any issues