refactor: better filename to avoid confusion

Author: wa0x6e

src/helpers/validation.ts renamed to src/helpers/spaceValidation.ts

@@ -8,8 +8,8 @@ import { containsFlaggedLinks, flaggedAddresses } from '../helpers/moderation';
 import { isMalicious } from '../helpers/monitoring';
 import db from '../helpers/mysql';
 import { getLimits, getSpaceType } from '../helpers/options';
+import { validateSpaceSettings } from '../helpers/spaceValidation';
 import { captureError, getQuorum, jsonParse, validateChoices } from '../helpers/utils';
-import { validateSpaceSettings } from '../helpers/validation';
 
 const scoreAPIUrl = process.env.SCORE_API_URL || 'https://score.snapshot.org';
 const broviderUrl = process.env.BROVIDER_URL || 'https://rpc.snapshot.org';

src/writer/proposal.ts

@@ -4,14 +4,14 @@ import { addOrUpdateSpace, getSpace } from '../helpers/actions';
 import log from '../helpers/log';
 import db from '../helpers/mysql';
 import { getLimit, getSpaceType } from '../helpers/options';
+import { validateSpaceSettings } from '../helpers/spaceValidation';
 import {
   addToWalletConnectWhitelist,
   clearStampCache,
   getSpaceController,
   jsonParse,
   removeFromWalletConnectWhitelist
 } from '../helpers/utils';
-import { validateSpaceSettings } from '../helpers/validation';
 
 const SNAPSHOT_ENV = process.env.NETWORK || 'testnet';
 

src/writer/settings.ts

@@ -17,9 +17,9 @@ jest.mock('../../../src/helpers/log', () => ({
   warn: jest.fn()
 }));
 
-import { validateSpaceSettings } from '../../../src/helpers/validation';
+import { validateSpaceSettings } from '../../../src/helpers/spaceValidation';
 
-describe('helpers/validation', () => {
+describe('helpers/spaceValidation', () => {
   describe('validateSpaceSettings()', () => {
     beforeEach(() => {
       jest.clearAllMocks();

test/unit/helpers/validation.test.ts renamed to test/unit/helpers/spaceValidation.test.ts

@@ -1,4 +1,10 @@
+// Mock validateSpaceSettings function
+jest.mock('../../../src/helpers/spaceValidation', () => ({
+  validateSpaceSettings: jest.fn()
+}));
+
 import omit from 'lodash/omit';
+import * as writer from '../../../src/writer/proposal';
 import { spacesGetSpaceFixtures } from '../../fixtures/space';
 import input from '../../fixtures/writer-payload/proposal.json';
 
@@ -92,16 +98,10 @@ jest.mock('../../../src/helpers/moderation', () => {
   };
 });
 
-// Mock validateSpaceSettings function
-jest.mock('../../../src/helpers/validation', () => ({
-  validateSpaceSettings: jest.fn()
-}));
-
 // Get the mocked function after the mock is created
-const { validateSpaceSettings: mockValidateSpaceSettings } = jest.requireMock('../../../src/helpers/validation');
-
-// Import after mocks are set up
-import * as writer from '../../../src/writer/proposal';
+const { validateSpaceSettings: mockValidateSpaceSettings } = jest.requireMock(
+  '../../../src/helpers/spaceValidation'
+);
 
 const mockGetProposalsCount = jest.spyOn(writer, 'getProposalsCount');
 mockGetProposalsCount.mockResolvedValue([
@@ -123,7 +123,7 @@ describe('writer/proposal', () => {
     // Default validateSpaceSettings to resolve (success)
     mockValidateSpaceSettings.mockResolvedValue(undefined);
   });
-  
+
   afterEach(jest.clearAllMocks);
 
   const msg = JSON.parse(input.msg);
@@ -175,7 +175,6 @@ describe('writer/proposal', () => {
       expect(mockGetProposalsCount).toHaveBeenCalledTimes(1);
     });
 
-
     describe('when the space has set a voting period', () => {
       const VOTING_PERIOD = 120;
       const msg = JSON.parse(input.msg);

test/unit/writer/proposal.test.ts

@@ -1,3 +1,9 @@
+// Mock validateSpaceSettings function
+jest.mock('../../../src/helpers/spaceValidation', () => ({
+  validateSpaceSettings: jest.fn()
+}));
+
+import { verify } from '../../../src/writer/settings';
 import { spacesGetSpaceFixtures } from '../../fixtures/space';
 import input from '../../fixtures/writer-payload/space.json';
 
@@ -101,16 +107,10 @@ jest.mock('@snapshot-labs/snapshot.js', () => {
   };
 });
 
-// Mock validateSpaceSettings function
-jest.mock('../../../src/helpers/validation', () => ({
-  validateSpaceSettings: jest.fn()
-}));
-
 // Get the mocked function after the mock is created
-const { validateSpaceSettings: mockValidateSpaceSettings } = jest.requireMock('../../../src/helpers/validation');
-
-// Import after mocks are set up
-import { verify } from '../../../src/writer/settings';
+const { validateSpaceSettings: mockValidateSpaceSettings } = jest.requireMock(
+  '../../../src/helpers/spaceValidation'
+);
 
 describe('writer/settings', () => {
   describe('verify()', () => {
@@ -234,12 +234,15 @@ describe('writer/settings', () => {
       it('calls validateSpaceSettings with correct parameters', async () => {
         await verify(input);
 
-        expect(mockValidateSpaceSettings).toHaveBeenCalledWith({
-          ...JSON.parse(input.msg).payload,
-          id: JSON.parse(input.msg).space,
-          deleted: spacesGetSpaceFixtures.deleted,
-          turbo: spacesGetSpaceFixtures.turbo
-        }, 'mainnet');
+        expect(mockValidateSpaceSettings).toHaveBeenCalledWith(
+          {
+            ...JSON.parse(input.msg).payload,
+            id: JSON.parse(input.msg).space,
+            deleted: spacesGetSpaceFixtures.deleted,
+            turbo: spacesGetSpaceFixtures.turbo
+          },
+          'mainnet'
+        );
       });
 
       it('passes when validateSpaceSettings succeeds and strategy count is valid', async () => {