feat: set proposal strategies value on proposal creation

fix: fix botched merge conflict

chore: remove typo

fix: fix typescript error

fix: fix lint error

fix: delete unused file

Author: wa0x6e

src/helpers/vpValue.ts renamed to src/helpers/strategiesValue.ts

@@ -1,40 +1,14 @@
-import hubDB from './mysql';
 import { fetchWithKeepAlive } from './utils';
 
 type Proposal = {
-  id: string;
   network: string;
   strategies: any[];
   start: number;
 };
 
 const OVERLORD_URL = 'https://overlord.snapshot.org';
-const CB_LAST = 5;
-const CB_ERROR = 0;
 
-export async function setProposalVpValue(proposal: Proposal) {
-  if (proposal.start > Date.now()) {
-    return;
-  }
-
-  try {
-    const vpValue = await getVpValue(proposal);
-
-    await hubDB.queryAsync('UPDATE proposals SET vp_value = ?, cb = ? WHERE id = ? LIMIT 1', [
-      vpValue,
-      CB_LAST,
-      proposal.id
-    ]);
-  } catch {
-    await hubDB.queryAsync('UPDATE proposals SET cb = ? WHERE id = ? LIMIT 1', [
-      CB_ERROR,
-      proposal.id
-    ]);
-    return;
-  }
-}
-
-async function getVpValue(proposal: Proposal) {
+export default async function getStrategiesValue(proposal: Proposal): Promise<number[]> {
   const init = {
     method: 'POST',
     headers: {

src/writer/proposal.ts

@@ -9,8 +9,8 @@ import { containsFlaggedLinks, flaggedAddresses } from '../helpers/moderation';
 import { isMalicious } from '../helpers/monitoring';
 import db from '../helpers/mysql';
 import { getLimits, getSpaceType } from '../helpers/options';
+import getStrategiesValue from '../helpers/strategiesValue';
 import { captureError, getQuorum, jsonParse, validateChoices } from '../helpers/utils';
-import { setProposalVpValue } from '../helpers/vpValue';
 
 const scoreAPIUrl = process.env.SCORE_API_URL || 'https://score.snapshot.org';
 const broviderUrl = process.env.BROVIDER_URL || 'https://rpc.snapshot.org';
@@ -242,9 +242,34 @@ export async function verify(body): Promise<any> {
   if (msg.payload.choices.length > choicesLimit) {
     return Promise.reject(`number of choices can not exceed ${choicesLimit}`);
   }
+
+  let strategiesValue: number[] = [];
+
+  try {
+    strategiesValue = await getStrategiesValue({
+      network: space.network,
+      start: msg.payload.start,
+      strategies: space.strategies
+    });
+
+    // Handle unlikely case where strategies value array length does not match strategies length
+    if (strategiesValue.length !== space.strategies.length) {
+      capture(new Error('Strategies value length mismatch'), {
+        space: space.id,
+        strategiesLength: space.strategies.length,
+        strategiesValue: JSON.stringify(strategiesValue)
+      });
+      return Promise.reject('failed to get strategies value');
+    }
+  } catch (e: any) {
+    console.log('unable to get strategies value', e.message);
+    return Promise.reject('failed to get strategies value');
+  }
+
+  return { strategiesValue };
 }
 
-export async function action(body, ipfs, receipt, id): Promise<void> {
+export async function action(body, ipfs, receipt, id, context): Promise<void> {
   const msg = jsonParse(body.msg);
   const space = msg.space;
 
@@ -302,7 +327,7 @@ export async function action(body, ipfs, receipt, id): Promise<void> {
     scores_state: 'pending',
     scores_total: 0,
     scores_updated: 0,
-    vp_value_by_strategy: JSON.stringify([]),
+    vp_value_by_strategy: JSON.stringify(context.strategiesValue),
     votes: 0,
     validation,
     flagged: +containsFlaggedLinks(msg.payload.body)
@@ -317,6 +342,4 @@ export async function action(body, ipfs, receipt, id): Promise<void> {
   `;
 
   await db.queryAsync(query, [proposal, space, author, space]);
-
-  setProposalVpValue({ ...proposal, strategies: spaceSettings.strategies });
 }

test/integration/writer/proposal.test.ts

@@ -45,7 +45,7 @@ describe('writer/proposal', () => {
         expect.hasAssertions();
         mockContainsFlaggedLinks.mockReturnValueOnce(true);
         const id = '0x01-flagged';
-        expect(await action(input, 'ipfs', 'receipt', id)).toBeUndefined();
+        expect(await action(input, 'ipfs', 'receipt', id, {})).toBeUndefined();
         expect(mockContainsFlaggedLinks).toBeCalledTimes(1);
 
         const [proposal] = await db.queryAsync('SELECT * FROM proposals WHERE id = ?', [id]);
@@ -57,7 +57,7 @@ describe('writer/proposal', () => {
       it('creates and does not flag proposal', async () => {
         expect.hasAssertions();
         const id = '0x02-non-flagged';
-        expect(await action(input, 'ipfs', 'receipt', id)).toBeUndefined();
+        expect(await action(input, 'ipfs', 'receipt', id, {})).toBeUndefined();
         expect(mockContainsFlaggedLinks).toBeCalledTimes(1);
 
         const [proposal] = await db.queryAsync('SELECT * FROM proposals WHERE id = ?', [id]);