fix: check for duplicate vote in verify #194
Conversation
| const votes = await db.queryAsync( | ||
| 'SELECT created FROM votes WHERE voter = ? AND proposal = ? AND space = ? ORDER BY created DESC LIMIT 1', | ||
| [body.address, msg.payload.proposal, msg.space] | ||
| ); | ||
|
|
||
| // Reject vote with later timestamp | ||
| if (votes[0]?.created > msgTs) { | ||
| return Promise.reject('already voted at later time'); | ||
| } |
There was a problem hiding this comment.
It is already checked in action right https://github.com/snapshot-labs/snapshot-sequencer/blob/use-alias-schema/src/writer/vote.ts#L148 ? maybe we should remove that if we already check it in verify
There was a problem hiding this comment.
I think the check inside action is to there in case some other threads/container are processing the same exact request, and is still needed, since we can't guarantee that the check inside verify is valid.
There was a problem hiding this comment.
mm better to handle parallel requests in requestDeduplicator, because this can cause duplicate query and code, meaning additional time to vote for users 🙈
There was a problem hiding this comment.
We should move all inside verify, after implementing requestDeduplicator #202
There was a problem hiding this comment.
mmm better to install deduplication first
|
Superseded by #216 , should still move the check from |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
If a vote already exist, we check that the new vote is more recent that the existing one before inserting, in the vote's
actionfunction.We should also do the same in the
verifyfunction, to avoid a call to get voting power.This kind of error is currently the slowest one: