feat: Add limits for voting delay and period (#961)

* feat: Add limits for voting delay and period

* fix

* Update test/examples/space.json

* Update src/schemas/space.json

* v0.11.1

* Update src/schemas/space.json

* Update test/examples/space.json

Author: ChaituVR

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@snapshot-labs/snapshot.js",
-  "version": "0.11.0",
+  "version": "0.11.1",
   "repository": "snapshot-labs/snapshot.js",
   "license": "MIT",
   "main": "dist/snapshot.cjs.js",
@@ -18,6 +18,7 @@
     "@ethersproject/units": "^5.7.0",
     "@ethersproject/wallet": "^5.6.2",
     "ajv": "^8.11.0",
+    "ajv-errors": "^3.0.0",
     "ajv-formats": "^2.1.1",
     "cross-fetch": "^3.1.6",
     "json-to-graphql-query": "^2.2.4",

src/schemas/space.json

@@ -282,11 +282,19 @@
           "properties": {
             "delay": {
               "type": "integer",
-              "minimum": 0
+              "minimum": 0,
+              "maximum": 2592000,
+              "errorMessage": {
+                "maximum": "Delay must be less than 30 days"
+              }
             },
             "period": {
               "type": "integer",
-              "minimum": 0
+              "minimum": 0,
+              "maximum": 15552000,
+              "errorMessage": {
+                "maximum": "Delay must be less than 180 days"
+              }
             },
             "type": {
               "type": "string",

src/utils.ts

@@ -7,6 +7,7 @@ import { namehash, ensNormalize } from '@ethersproject/hash';
 import { jsonToGraphQLQuery } from 'json-to-graphql-query';
 import Ajv from 'ajv';
 import addFormats from 'ajv-formats';
+import addErrors from 'ajv-errors';
 import Multicaller from './utils/multicaller';
 import { getSnapshots } from './utils/blockfinder';
 import getProvider from './utils/provider';
@@ -45,6 +46,7 @@ const ajv = new Ajv({
 });
 // @ts-ignore
 addFormats(ajv);
+addErrors(ajv);
 
 ajv.addFormat('address', {
   validate: (value: string) => {

test/examples/space.json

@@ -28,5 +28,9 @@
   "validation": {
     "name": "basic",
     "params": {}
+  },
+  "voting":{
+    "delay": 2592000,
+    "period": 15552000
   }
 }

yarn.lock

@@ -1147,6 +1147,11 @@ aggregate-error@^3.0.0:
     clean-stack "^2.0.0"
     indent-string "^4.0.0"
 
+ajv-errors@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/ajv-errors/-/ajv-errors-3.0.0.tgz#e54f299f3a3d30fe144161e5f0d8d51196c527bc"
+  integrity sha512-V3wD15YHfHz6y0KdhYFjyy9vWtEVALT9UrxfN3zqlI6dMioHnJrqOYfyPKol3oqrnCM9uwkcdCwkJ0WUcbLMTQ==
+
 ajv-formats@^2.1.1:
   version "2.1.1"
   resolved "https://registry.yarnpkg.com/ajv-formats/-/ajv-formats-2.1.1.tgz#6e669400659eb74973bbf2e33327180a0996b520"