fix: return the same json error on network error (#900)

* fix: handle JSON-RPC errors from score-api

* fix: return the same json error on network error

* chore: remove only test

Author: wa0x6e

src/utils.ts

@@ -247,6 +247,9 @@ export async function getScores(
       ? obj.result
       : obj.result[options.returnValue || 'scores'];
   } catch (e) {
+    if (e.errno) {
+      return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
+    }
     return Promise.reject(e);
   }
 }
@@ -278,10 +281,18 @@ export async function getVp(
       }
     })
   };
-  const res = await fetch(options.url, init);
-  const json = await res.json();
-  if (json.error) return Promise.reject(json.error);
-  if (json.result) return json.result;
+
+  try {
+    const res = await fetch(options.url, init);
+    const json = await res.json();
+    if (json.error) return Promise.reject(json.error);
+    if (json.result) return json.result;
+  } catch (e) {
+    if (e.errno) {
+      return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
+    }
+    return Promise.reject(e);
+  }
 }
 
 export async function validate(
@@ -311,10 +322,18 @@ export async function validate(
       }
     })
   };
-  const res = await fetch(options.url, init);
-  const json = await res.json();
-  if (json.error) return Promise.reject(json.error);
-  return json.result;
+
+  try {
+    const res = await fetch(options.url, init);
+    const json = await res.json();
+    if (json.error) return Promise.reject(json.error);
+    return json.result;
+  } catch (e) {
+    if (e.errno) {
+      return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
+    }
+    return Promise.reject(e);
+  }
 }
 
 export function validateSchema(schema, data) {
@@ -417,8 +436,7 @@ export async function getDelegatesBySpace(
   snapshot = 'latest',
   options: any = {}
 ) {
-  const subgraphUrl =
-    options.subgraphUrl || SNAPSHOT_SUBGRAPH_URL[network];
+  const subgraphUrl = options.subgraphUrl || SNAPSHOT_SUBGRAPH_URL[network];
   if (!subgraphUrl) {
     return Promise.reject(
       `Delegation subgraph not available for network ${network}`

test/e2e/utils/getScores.spec.ts

@@ -2,10 +2,29 @@ import { test, expect, describe } from 'vitest';
 import { getScores } from '../../../src/utils';
 
 describe('test getScores', () => {
-  test('getScores should returns a promise rejection on error from score-api', async () => {
+  test('getScores should return a promise rejection on error from score-api', async () => {
     expect.assertions(1);
     await expect(
       getScores('test.eth', [], '1', ['0x0'])
     ).to.rejects.toHaveProperty('code');
   });
+
+  test('getScores should return a promise rejection with JSON-RPC format on network error', async () => {
+    expect.assertions(1);
+    await expect(
+      getScores(
+        'test.eth',
+        [],
+        '1',
+        [''],
+        'latest',
+        'https://score-null.snapshot.org'
+      )
+    ).to.rejects.toEqual({
+      code: 'ENOTFOUND',
+      message:
+        'FetchError: request to https://score-null.snapshot.org/api/scores failed, reason: getaddrinfo ENOTFOUND score-null.snapshot.org',
+      data: ''
+    });
+  });
 });