conditional cheats not working

[jiangsheng]

I have a conditional cheat in the form of AABBCC:00?10, basically if the value at AABBCC is 0, write 0x10 to the address.

The game starts with memory zero out, so 0x10 is written to the memory address AABBCC, and c.cond_true is set to true.

However, after starting a new game, the value at AABBCC is again zero , and this time, 10 is not written, because nether path in
if (c.conditional) will be taken in S9xUpdateCheatInMemory. c.cond_true is set to true, and both c.saved_byte and c.cond_byte are 0.

I could not deduct the meaning of cond_true from its name or usage. so I don't really know how to fix this. What is it used for?

[OV2]

Maybe it was meant to only trigger once until the condition is no longer true...
You are right that at the moment it does not really make sense. I will take a look when I can find some time.

[bearoso]

I think the cond_true variable was there to avoid restoring a garbage saved value when the condition never triggered. These variable names aren't very descriptive, and I should probably make them more verbose.

96daa0e should fix this bug.