Additionalpropertiesfalse generates invalid java code with mapstring (#369)

* Fix: Handle additionalProperties false correctly - do not generate Map field

When additionalProperties is explicitly set to false, the generator should not
create a Map field. Previously, any presence of additionalProperties would
generate a Map regardless of its boolean value.

Changes:
- ModelBuilder.java: Updated processAdditionalProperties() to check if boolean
  false and skip Map generation
- ModelBuilder.java: Updated setFieldType() to handle boolean false case
- ModelBuilder.java: Updated getMapTypeObject() to safely handle boolean nodes
- Added testAdditionalPropertiesFalse test case with YAML, expected DTO, and API
- Bump patch version to 6.3.2 (bug fix)

Fixes issue #367: additionalProperties false generates invalid Java code"

* Add testing

* fix case issue on tests

Author: jemacineiras

multiapi-engine/pom.xml

@@ -4,7 +4,7 @@
 
   <groupId>com.sngular</groupId>
   <artifactId>multiapi-engine</artifactId>
-  <version>6.3.1</version>
+  <version>6.3.2</version>
   <packaging>jar</packaging>
 
   <properties>

multiapi-engine/src/main/java/com/sngular/api/generator/plugin/common/tools/ModelBuilder.java

@@ -539,13 +539,17 @@ private static List<SchemaFieldObject> processAdditionalProperties(
     final var fieldObjectArrayList = new ArrayList<SchemaFieldObject>();
 
     final var addPropObj = ApiTool.getAdditionalProperties(schema);
-    if (TypeConstants.isBoolean(addPropObj.asText())) {
-      fieldObjectArrayList
-          .add(SchemaFieldObject
-                   .builder()
-                   .baseName(fieldName)
-                   .dataType(SchemaFieldObjectType.fromTypeList(TypeConstants.MAP, TypeConstants.OBJECT))
-                   .build());
+    if (Objects.nonNull(addPropObj) && addPropObj.isBoolean()) {
+      if (addPropObj.asBoolean()) {
+        fieldObjectArrayList
+            .add(SchemaFieldObject
+                     .builder()
+                     .baseName(fieldName)
+                     .dataType(SchemaFieldObjectType.fromTypeList(TypeConstants.MAP, TypeConstants.OBJECT))
+                     .build());
+      } else {
+        return fieldObjectArrayList;
+      }
     } else if (ApiTool.hasRef(addPropObj)) {
       final String refSchemaName = MapperUtil.getPojoNameFromRef(addPropObj, specFile, null);
       fieldObjectArrayList.add(processRef(fieldName, addPropObj,
@@ -633,12 +637,20 @@ private static void setFieldType(
       field.setDataType(SchemaFieldObjectType.fromTypeList(TypeConstants.ARRAY, typeArray));
       field.setImportClass(getImportClass(typeArray));
     } else if (ApiTool.hasAdditionalProperties(schemaProperty)) {
-      final String typeObject = getMapTypeObject(schemaProperty, specFile);
-      field.setDataType(SchemaFieldObjectType.fromTypeList(TypeConstants.MAP, typeObject));
-      field.setImportClass(getImportClass(typeObject));
-
+      final JsonNode apNode = ApiTool.getAdditionalProperties(schemaProperty);
+      if (Objects.nonNull(apNode) && apNode.isBoolean()) {
+        if (apNode.asBoolean()) {
+          final String typeObject = TypeConstants.OBJECT;
+          field.setDataType(SchemaFieldObjectType.fromTypeList(TypeConstants.MAP, typeObject));
+          field.setImportClass(getImportClass(typeObject));
+        } // if boolean false -> do not set map type
+      } else {
+        final String typeObject = getMapTypeObject(schemaProperty, specFile);
+        field.setDataType(SchemaFieldObjectType.fromTypeList(TypeConstants.MAP, typeObject));
+        field.setImportClass(getImportClass(typeObject));
+      }
     } else if (ApiTool.isObject(schemaProperty)) {
-      var typeObject = ApiTool.getType(schemaProperty);
+      String typeObject = ApiTool.getType(schemaProperty);
       if (ApiTool.hasRef(schemaProperty)) {
         typeObject = MapperUtil.getPojoNameFromRef(schema, specFile, null);
       }
@@ -649,10 +661,10 @@ private static void setFieldType(
 
   private static String getMapTypeObject(final JsonNode schema, final CommonSpecFile specFile) {
     final String type;
-    if (ApiTool.isBoolean(ApiTool.getAdditionalProperties(schema))) {
+    final JsonNode additionalProperties = ApiTool.getAdditionalProperties(schema);
+    if (Objects.nonNull(additionalProperties) && additionalProperties.isBoolean()) {
       type = TypeConstants.OBJECT;
     } else {
-      final JsonNode additionalProperties = ApiTool.getAdditionalProperties(schema);
       if (ApiTool.hasRef(additionalProperties)) {
         type = MapperUtil.getPojoNameFromRef(additionalProperties, specFile, null);
       } else if (ApiTool.isObject(schema)) {