Merge pull request #218 from snitch-org/empty-name

Fix #216

Author: cschreib

include/snitch/snitch_registry.hpp

@@ -53,7 +53,7 @@ struct fixture_name_and_tags {
     std::string_view tags    = {};
 };
 
-SNITCH_EXPORT std::string_view
+SNITCH_EXPORT bool
 make_full_name(small_string<max_test_name_length>& buffer, const test_id& id) noexcept;
 
 template<typename T, typename F>

src/snitch_registry.cpp

@@ -140,20 +140,14 @@ make_capture_buffer(const capture_state& captures) noexcept {
 }
 } // namespace
 
-std::string_view
-make_full_name(small_string<max_test_name_length>& buffer, const test_id& id) noexcept {
+bool make_full_name(small_string<max_test_name_length>& buffer, const test_id& id) noexcept {
     buffer.clear();
+
     if (id.type.length() != 0) {
-        if (!append(buffer, id.name, " <", id.type, ">")) {
-            return {};
-        }
+        return append(buffer, id.name, " <", id.type, ">");
     } else {
-        if (!append(buffer, id.name)) {
-            return {};
-        }
+        return append(buffer, id.name);
     }
-
-    return buffer.str();
 }
 } // namespace snitch::impl
 
@@ -363,7 +357,7 @@ registry::add_impl(const test_id& id, const source_location& location, impl::tes
     test_list.push_back(impl::test_case{id, location, func});
 
     small_string<max_test_name_length> buffer;
-    if (impl::make_full_name(buffer, test_list.back().id).empty()) {
+    if (!impl::make_full_name(buffer, test_list.back().id)) {
         using namespace snitch::impl;
         print(
             make_colored("error:", with_color, color::fail),
@@ -849,8 +843,9 @@ bool run_tests_impl(registry& r, const cli::input& args) noexcept {
 
             // Evaluate each filter (provided as separate command-line argument).
             for (const auto& filter : filter_strings) {
-                const filter_result sub_result =
-                    is_filter_match_id(impl::make_full_name(buffer, id), id.tags, filter);
+                impl::make_full_name(buffer, id);
+
+                const filter_result sub_result = is_filter_match_id(buffer.str(), id.tags, filter);
 
                 if (!result.has_value()) {
                     // The first filter initialises the result.

tests/runtime_tests/registry.cpp

@@ -71,6 +71,31 @@ TEST_CASE("add regular test no tags", "[registry]") {
     CHECK_EVENT_TEST_ID(framework.events[1], test.id);
 }
 
+TEST_CASE("add regular test no name", "[registry]") {
+    mock_framework framework;
+
+    test_called = false;
+    framework.registry.add({""}, SNITCH_CURRENT_LOCATION, []() { test_called = true; });
+
+    REQUIRE(framework.get_num_registered_tests() == 1u);
+
+    auto& test = framework.registry.test_cases()[0];
+    CHECK(test.id.name == ""sv);
+    CHECK(test.id.tags == ""sv);
+    CHECK(test.id.type == ""sv);
+    REQUIRE(test.func != nullptr);
+
+    framework.setup_reporter();
+    framework.registry.run(test);
+
+    CHECK(test_called == true);
+    REQUIRE(framework.events.size() == 2u);
+    CHECK(framework.is_event<owning_event::test_case_started>(0u));
+    CHECK(framework.is_event<owning_event::test_case_ended>(1u));
+    CHECK_EVENT_TEST_ID(framework.events[0], test.id);
+    CHECK_EVENT_TEST_ID(framework.events[1], test.id);
+}
+
 TEST_CASE("add template test", "[registry]") {
     for (bool with_type_list : {false, true}) {
         mock_framework framework;