Pulling v0.3.1 container fails with "manifest unknown"

[sjmonson]

Attempting to use the v0.3.1 version of this action results in an image pull error. May be related to #97.

[ubbeK]

I get the same thing

$ docker pull ghcr.io/snok/container-retention-policy:v3.0.1
v3.0.1: Pulling from snok/container-retention-policy
manifest unknown
$ echo $?
1
$ docker pull ghcr.io/snok/container-retention-policy:v3.0.0
v3.0.0: Pulling from snok/container-retention-policy
7bd4f6f89c2a: Pull complete
cd197ae42f02: Pull complete
Digest: sha256:381e0dc04f7624e3504eb4f85ea82c6e782287d1b1bc75edf7fe071f08300b13
Status: Downloaded newer image for ghcr.io/snok/container-retention-policy:v3.0.0
ghcr.io/snok/container-retention-policy:v3.0.0
$ echo $?
0

What has changed between these patch versions?

[makkes]

The 3.0.1 images are broken because the are referencing manifests that don't exist:

$ crane manifest ghcr.io/snok/container-retention-policy:v3.0.1 | jq '.manifests[0].digest' -r | xargs -I{} crane manifest ghcr.io/snok/container-retention-policy@{}
Error: fetching manifest ghcr.io/snok/container-retention-policy@sha256:512d3d041f72a18953edccc40cd5100ac2f8c4d3eec7ad003ff69b7ff19e7640: GET https://ghcr.io/v2/snok/container-retention-policy/manifests/sha256:512d3d041f72a18953edccc40cd5100ac2f8c4d3eec7ad003ff69b7ff19e7640: MANIFEST_UNKNOWN: manifest unknown

For comparison:

$ crane manifest ghcr.io/snok/container-retention-policy:v3.0.0 | jq '.manifests[0].digest' -r | xargs -I{} crane manifest ghcr.io/snok/container-retention-policy@{}
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.manifest.v1+json",
  "config": {
    "mediaType": "application/vnd.oci.image.config.v1+json",
    "digest": "sha256:65fa10dd0f679e4045875f52d537652931aa5c5423cdf452e4ab86a4be35802b",
    "size": 1623
  },
  "layers": [
    {
      "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
      "digest": "sha256:7bd4f6f89c2a16da2651dc594018fe938a1e8ad10cd88200dfe6446f9fe7efb6",
      "size": 481
    },
    {
      "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
      "digest": "sha256:cd197ae42f023bfd3787b7edf20b89f572f1beba8d0d7bf24ff0b0bc1e99aa66",
      "size": 2119892
    }
  ]
}

Something in the image build process has changed that leads to broken images being pushed to GHCR.

[makkes]

Very likely caused by this commit.

[jens-maus]

So please @sondrelg get this fix, because one of my depending projects and the activated dependabot is always suggesting to update container-retention-policy to v3.0.1 which of course is broken ATM.

[sondrelg]

Sorry about this. Seems like the release workflow didn't quite do the job here. I've reuploaded v3.0.1 and it seems to work in tests. Please let me know otherwise 👍

[makkes]

Sorry about this. Seems like the release workflow didn't quite do the job here. I've reuploaded v3.0.1 and it seems to work in tests. Please let me know otherwise 👍

Thanks for tackling this issue! It still doesn't seem to work, though:

crane manifest ghcr.io/snok/container-retention-policy:v3.0.1 | jq '.manifests[0].digest' -r | xargs -I{} crane manifest ghcr.io/snok/container-retention-policy@{}
Error: fetching manifest ghcr.io/snok/container-retention-policy@sha256:32e562cd449bfcaa4d94693124fda23e61436e234e19abd094ae802f9ad3c2e5: GET https://ghcr.io/v2/snok/container-retention-policy/manifests/sha256:32e562cd449bfcaa4d94693124fda23e61436e234e19abd094ae802f9ad3c2e5: MANIFEST_UNKNOWN: manifest unknown

$ podman pull ghcr.io/snok/container-retention-policy:v3.0.1
Trying to pull ghcr.io/snok/container-retention-policy:v3.0.1...
Error: copying system image from manifest list: determining manifest MIME type for docker://ghcr.io/snok/container-retention-policy:v3.0.1: reading manifest sha256:4552213b344331ea7e0e78587149792de5084eb04b8ce5f9c4855205c588021f in ghcr.io/snok/container-retention-policy: manifest unknown

[jens-maus]

Same here. The v3.0.1 version can still not be pulled directly even via docker pull. See:

$ docker pull ghcr.io/snok/container-retention-policy:v3.0.1
v3.0.1: Pulling from snok/container-retention-policy
manifest unknown

[sondrelg]

Aha, I see the problem now. We run this live test workflow to ensure the action works, and I had not remembered to document that it needed to be updated when a new version is released 😮‍💨

I'll reupload v3.0.1 once more and make sure it's not deleted by our test-workflow 👍

[jens-maus]

I'll reupload v3.0.1 once more and make sure it's not deleted by our test-workflow 👍

Yes, now it seems to finally work:

$ docker pull ghcr.io/snok/container-retention-policy:v3.0.1
v3.0.1: Pulling from snok/container-retention-policy
3b236c8aad68: Pull complete 
02426edb21b5: Pull complete 
Digest: sha256:3c1e7d40fbba1ca07dbd0d853039c47ee83c510345c8da82135d57a939321d90
Status: Downloaded newer image for ghcr.io/snok/container-retention-policy:v3.0.1
ghcr.io/snok/container-retention-policy:v3.0.1

[sjmonson]

Confirmed works now. Thanks @sondrelg!

[makkes]

Thanks @sondrelg! Much appreciated.

[salimane]

it is happening again

docker pull ghcr.io/snok/container-retention-policy:v3.0.1
v3.0.1: Pulling from snok/container-retention-policy
manifest unknown

[sondrelg]

Strange. I'll re-upload the image when I get a chance.