SNOW-2306184: config refactor - simplify abstractions

Author: sfc-gh-mraba

src/snowflake/cli/api/config_ng/__init__.py

@@ -15,8 +15,8 @@
 """
 Enhanced Configuration System - Next Generation (NG)
 
-This package implements a layered, extensible configuration system with:
-- Clear precedence rules (CLI > Environment > Files)
+This package implements a simple, extensible configuration system with:
+- List-order precedence (explicit ordering in source list)
 - Migration support (SnowCLI and SnowSQL compatibility)
 - Complete resolution history tracking
 - Read-only, immutable configuration sources
@@ -26,20 +26,8 @@
     ConfigValue,
     ResolutionEntry,
     ResolutionHistory,
-    SourcePriority,
     ValueSource,
 )
-from snowflake.cli.api.config_ng.env_handlers import (
-    SNOWSQL_TO_SNOWCLI_KEY_MAPPINGS,
-    SnowCliEnvHandler,
-    SnowSqlEnvHandler,
-)
-from snowflake.cli.api.config_ng.file_handlers import (
-    SNOWSQL_CONFIG_KEY_MAPPINGS,
-    IniFileHandler,
-    TomlFileHandler,
-    get_snowsql_config_paths,
-)
 from snowflake.cli.api.config_ng.resolution_logger import (
     check_value_source,
     explain_configuration,
@@ -56,38 +44,34 @@
     ResolutionHistoryTracker,
 )
 from snowflake.cli.api.config_ng.sources import (
-    CliArgumentSource,
-    ConfigurationSource,
-    EnvironmentSource,
-    FileSource,
+    CliConfigFile,
+    CliEnvironment,
+    CliParameters,
+    ConnectionsConfigFile,
+    SnowSQLConfigFile,
+    SnowSQLEnvironment,
 )
 
 __all__ = [
     "check_value_source",
-    "CliArgumentSource",
+    "CliConfigFile",
+    "CliEnvironment",
+    "CliParameters",
     "ConfigurationResolver",
-    "ConfigurationSource",
     "ConfigValue",
-    "EnvironmentSource",
+    "ConnectionsConfigFile",
     "explain_configuration",
     "export_resolution_history",
-    "FileSource",
     "format_summary_for_display",
     "get_resolution_summary",
     "get_resolver",
-    "get_snowsql_config_paths",
     "is_resolution_logging_available",
     "ResolutionEntry",
     "ResolutionHistory",
     "ResolutionHistoryTracker",
     "show_all_resolution_chains",
     "show_resolution_chain",
-    "SnowCliEnvHandler",
-    "SNOWSQL_CONFIG_KEY_MAPPINGS",
-    "SNOWSQL_TO_SNOWCLI_KEY_MAPPINGS",
-    "SnowSqlEnvHandler",
-    "IniFileHandler",
-    "SourcePriority",
-    "TomlFileHandler",
+    "SnowSQLConfigFile",
+    "SnowSQLEnvironment",
     "ValueSource",
 ]

src/snowflake/cli/api/config_ng/core.py

@@ -16,7 +16,6 @@
 Core abstractions for the enhanced configuration system.
 
 This module implements the foundational data structures and interfaces:
-- SourcePriority: Defines precedence levels
 - ConfigValue: Immutable value container with provenance
 - ValueSource: Common protocol for all configuration sources
 - ResolutionHistory: Tracks the complete resolution process
@@ -27,21 +26,9 @@
 from abc import ABC, abstractmethod
 from dataclasses import dataclass, field
 from datetime import datetime
-from enum import Enum
 from typing import Any, Callable, Dict, List, Optional
 
 
-class SourcePriority(Enum):
-    """
-    Defines top-level precedence for configuration sources.
-    Lower numeric value = higher priority.
-    """
-
-    CLI_ARGUMENT = 1  # Highest: command-line arguments
-    ENVIRONMENT = 2  # Medium: environment variables
-    FILE = 3  # Lowest: configuration files
-
-
 @dataclass(frozen=True)
 class ConfigValue:
     """
@@ -52,7 +39,6 @@ class ConfigValue:
     key: str
     value: Any
     source_name: str
-    priority: SourcePriority
     raw_value: Optional[Any] = None
 
     def __repr__(self) -> str:
@@ -68,17 +54,15 @@ def from_source(
         key: str,
         raw_value: str,
         source_name: str,
-        priority: SourcePriority,
         value_parser: Optional[Callable[[str], Any]] = None,
     ) -> ConfigValue:
         """
-        Factory method to create ConfigValue from a source handler.
+        Factory method to create ConfigValue from a source.
 
         Args:
             key: Configuration key
             raw_value: Raw string value from the source
             source_name: Name of the configuration source
-            priority: Source priority level
             value_parser: Optional parser function; if None, raw_value is used as-is
 
         Returns:
@@ -89,32 +73,26 @@ def from_source(
             key=key,
             value=parsed_value,
             source_name=source_name,
-            priority=priority,
             raw_value=raw_value,
         )
 
 
 class ValueSource(ABC):
     """
-    Common interface for all configuration sources and handlers.
+    Common interface for all configuration sources.
     All implementations are READ-ONLY discovery mechanisms.
+    Precedence is determined by the order sources are provided to the resolver.
     """
 
     @property
     @abstractmethod
     def source_name(self) -> str:
         """
         Unique identifier for this source.
-        Examples: "cli_arguments", "snowflake_cli_env", "toml:connections"
+        Examples: "cli_arguments", "snowsql_config", "cli_env"
         """
         ...
 
-    @property
-    @abstractmethod
-    def priority(self) -> SourcePriority:
-        """Top-level priority for this source."""
-        ...
-
     @abstractmethod
     def discover(self, key: Optional[str] = None) -> Dict[str, ConfigValue]:
         """
@@ -241,7 +219,6 @@ def to_dict(self) -> dict:
                     "source": entry.config_value.source_name,
                     "value": entry.config_value.value,
                     "raw_value": entry.config_value.raw_value,
-                    "priority": entry.config_value.priority.name,
                     "was_used": entry.was_used,
                     "overridden_by": entry.overridden_by,
                     "timestamp": entry.timestamp.isoformat(),