Fix bugs and address feedbacks

Author: sfc-gh-zzhu

src/snowflake/cli/_plugins/remote/commands.py

@@ -134,7 +134,13 @@ def _display_service_result(
             f"✓ Remote Development Environment {service_name} is already running."
         )
 
-    cc.message(f"VS Code Server URL: {url}")
+    if url:
+        cc.message(f"VS Code Server URL: {url}")
+    else:
+        cc.warning(
+            "VS Code Server URL is not yet available. The service is still initializing its public endpoint. "
+            f"Run 'snow remote start {service_name}' again in a moment to retrieve the URL, or use 'snow remote list' to check status."
+        )
 
     # Log detailed information at debug level
     if stage:
@@ -187,7 +193,7 @@ def _handle_remote_service(
             external_access=eai_name,
             stage=stage,
             image=image,
-            generate_ssh_key=(ssh_mode is not None and not no_ssh_key),
+            generate_ssh_key=not no_ssh_key,
         )
 
         # Display service result

src/snowflake/cli/_plugins/remote/constants.py

@@ -113,7 +113,7 @@ class ServiceResult(enum.Enum):
 ENABLE_HEALTH_CHECKS = "false"
 
 # Endpoint readiness validation settings
-DEFAULT_ENDPOINT_TIMEOUT_MINUTES = 5  # Maximum time to wait for endpoint readiness
+DEFAULT_ENDPOINT_TIMEOUT_MINUTES = 2  # Maximum time to wait for endpoint readiness
 ENDPOINT_CHECK_INTERVAL_SECONDS = 5  # Interval between endpoint health checks
 ENDPOINT_REQUEST_TIMEOUT_SECONDS = 10  # HTTP request timeout for individual checks
 

src/snowflake/cli/_plugins/remote/manager.py

@@ -39,6 +39,7 @@
     get_existing_ssh_key,
     get_ssh_key_paths,
     launch_ide,
+    sanitize_identifier_component,
     setup_ssh_config_with_token,
     validate_endpoint_ready,
     validate_service_name,
@@ -180,8 +181,9 @@ def _resolve_service_name(self, name_input: str) -> str:
 
         # Otherwise, treat as customer input name and add prefix with Snowflake username
         snowflake_username = self._get_current_snowflake_user()
+        safe_user = sanitize_identifier_component(snowflake_username)
         # Convert to uppercase to match Snowflake service naming convention
-        return f"{SERVICE_NAME_PREFIX}_{snowflake_username}_{name_input}".upper()
+        return f"{SERVICE_NAME_PREFIX}_{safe_user}_{name_input}".upper()
 
     def _warn_about_config_changes(
         self,
@@ -294,17 +296,13 @@ def _handle_existing_service(
             ServiceStatus.DELETING.value,
             ServiceStatus.DELETED.value,
         ]:
-            log.debug(
-                "Service %s is in failed/error/deleting state (%s), will recreate...",
-                service_name,
-                current_status,
+            cc.warning(
+                f"Service {service_name} is in failed/error/deleting state ({current_status}), will recreate..."
             )
             return None
         else:
-            log.debug(
-                "Service %s has unknown status '%s', will recreate...",
-                service_name,
-                current_status,
+            cc.warning(
+                f"Service {service_name} has unknown status '{current_status}', will recreate..."
             )
             return None
 
@@ -565,40 +563,54 @@ def get_server_ui_url(self, service_name: str) -> str:
 
     def get_validated_server_ui_url(
         self, service_name: str, timeout_minutes: int = DEFAULT_ENDPOINT_TIMEOUT_MINUTES
-    ) -> str:
+    ) -> Optional[str]:
         """
-        Get server UI URL and validate that the endpoint is ready and responding.
+        Get server UI URL and best-effort validate that the endpoint is ready.
 
-        This method combines URL retrieval and endpoint validation to ensure the returned URL
-        is immediately usable by the user.
+        This method retrieves the endpoint URL and attempts to validate readiness.
+        If validation cannot be performed or the endpoint is not yet ready, a warning is
+        displayed but users can proceed without being blocked.
 
         Args:
             service_name: Full name of the service
             timeout_minutes: Maximum time to wait for endpoint readiness
 
         Returns:
-            Validated server UI URL
-
-        Raises:
-            CliError: If URL cannot be retrieved or endpoint doesn't become ready
+            Server UI URL (returned even if validation fails)
         """
         # Get the server UI URL
         url = self.get_server_ui_url(service_name)
 
+        # Best-effort validation: warn and continue on any issue
         try:
             self.snowpark_session.sql(
                 "ALTER SESSION SET python_connector_query_result_format = 'JSON'"
             ).collect()
             token = self.snowpark_session.connection.rest.token
-        except Exception as e:
-            raise CliError(
-                f"Failed to get authentication token for endpoint validation: {e}"
-            )
 
-        if not token:
-            raise CliError("No authentication token available for endpoint validation")
+            if not token:
+                cc.warning(
+                    "Could not obtain authentication token to validate endpoint readiness. "
+                    "Proceeding without validation."
+                )
+            else:
+                try:
+                    validate_endpoint_ready(
+                        url, token, SERVER_UI_ENDPOINT_NAME, timeout_minutes
+                    )
+                except Exception as e:
+                    # Do not block user; just warn that the endpoint may still be initializing
+                    cc.warning(
+                        f"Endpoint '{SERVER_UI_ENDPOINT_NAME}' may still be initializing. ({e}). Skipping validation."
+                    )
+                    return None
 
-        validate_endpoint_ready(url, token, SERVER_UI_ENDPOINT_NAME, timeout_minutes)
+        except Exception as e:
+            # Token/session issues: warn and proceed
+            cc.warning(
+                f"Skipping endpoint readiness check due to session/token issue: {e}. "
+                "Proceeding without validation."
+            )
 
         return url
 

src/snowflake/cli/_plugins/remote/utils.py

@@ -97,6 +97,39 @@ def validate_service_name(service_name: str) -> None:
         )
 
 
+def sanitize_identifier_component(
+    value: str, default_value: str = "DEFAULT_USER"
+) -> str:
+    """
+    Sanitize a string to be a safe component of a Snowflake identifier.
+
+    - Replace invalid characters with underscores
+    - Collapse multiple underscores
+    - Ensure it starts with a letter or underscore (prefix underscore if needed)
+    - Fall back to 'USER' if the result is empty
+
+    Args:
+        value: Input string (e.g., username) to sanitize
+
+    Returns:
+        Sanitized identifier-safe component string
+    """
+    if not value:
+        return default_value
+
+    # Replace any character not allowed in identifiers with underscore
+    sanitized = re.sub(r"[^A-Za-z0-9_]", "_", value)
+
+    # Collapse multiple consecutive underscores
+    sanitized = re.sub(r"_+", "_", sanitized)
+
+    # If everything was stripped to empty or underscores only, fallback
+    if not sanitized or sanitized.strip("_") == "":
+        return default_value
+
+    return sanitized
+
+
 class SnowflakeRegion(TypedDict):
     region_group: Optional[str]
     snowflake_region: str
@@ -667,7 +700,7 @@ def validate_endpoint_ready(
     Raises:
         CliError: If endpoint doesn't become ready within timeout or authentication fails
     """
-    log.debug("Validating endpoint readiness for %s at %s", endpoint_name, endpoint_url)
+    cc.step(f"Validating endpoint readiness for {endpoint_name} at {endpoint_url}")
 
     timeout_seconds = timeout_minutes * 60
     start_time = time.time()
@@ -708,6 +741,13 @@ def validate_endpoint_ready(
                 response.status_code,
                 ENDPOINT_CHECK_INTERVAL_SECONDS,
             )
+            elapsed = int(time.time() - start_time)
+            log.debug(
+                "Still waiting for '%s'... elapsed %ds (last status: %d).",
+                endpoint_name,
+                elapsed,
+                response.status_code,
+            )
 
         except Exception as e:
             log.debug(
@@ -716,6 +756,13 @@ def validate_endpoint_ready(
                 attempts,
                 str(e),
             )
+            elapsed = int(time.time() - start_time)
+            log.debug(
+                "Still waiting for '%s'... elapsed %ds (last error: %s).",
+                endpoint_name,
+                elapsed,
+                str(e),
+            )
 
         # Wait before next attempt
         time.sleep(ENDPOINT_CHECK_INTERVAL_SECONDS)

tests/remote/test_commands.py

@@ -62,7 +62,7 @@ def test_start_command_success(self, mock_start, runner):
             external_access=None,
             stage=None,
             image=None,
-            generate_ssh_key=False,
+            generate_ssh_key=True,
         )
 
     @patch.object(RemoteManager, "start")

tests/remote/test_manager.py

@@ -64,6 +64,38 @@ def test_resolve_service_name_with_customer_name(self):
             result = manager._resolve_service_name("myproject")  # noqa: SLF001
         assert result == f"{SERVICE_NAME_PREFIX}_SNOWFLAKE_USER_MYPROJECT"
 
+    def test_resolve_service_name_sanitizes_username_special_chars(self):
+        """Username with invalid chars should be sanitized in service name."""
+        manager = RemoteManager()
+
+        with patch.object(
+            manager, "_get_current_snowflake_user", return_value="john.doe+eng@acme-co"
+        ):
+            result = manager._resolve_service_name("proj1")  # noqa: SLF001
+
+        # Expected: non-alphanumeric replaced with underscores and collapsed
+        # "john.doe+eng@acme-co" -> "john_doe_eng_acme_co" then full name uppercased
+        assert result == f"{SERVICE_NAME_PREFIX}_JOHN_DOE_ENG_ACME_CO_PROJ1"
+
+    def test_resolve_service_name_username_empty_uses_default(self):
+        """Empty username falls back to DEFAULT_USER in service name."""
+        manager = RemoteManager()
+
+        with patch.object(manager, "_get_current_snowflake_user", return_value=""):
+            result = manager._resolve_service_name("proj")  # noqa: SLF001
+
+        assert result == f"{SERVICE_NAME_PREFIX}_DEFAULT_USER_PROJ"
+
+    def test_resolve_service_name_keeps_project_name_unchanged_except_case(self):
+        """Project name is not sanitized, only uppercased in final name."""
+        manager = RemoteManager()
+
+        with patch.object(manager, "_get_current_snowflake_user", return_value="alice"):
+            # name contains dashes and dots; per current behavior, it is used as-is and then uppercased
+            result = manager._resolve_service_name("my-project.v1")  # noqa: SLF001
+
+        assert result == f"{SERVICE_NAME_PREFIX}_ALICE_MY-PROJECT.V1"
+
     def test_resolve_service_name_with_full_service_name(self):
         """Test that full service names are passed through unchanged."""
         manager = RemoteManager()