Skip to content

Commit 2479227

Browse files
committed
SNOW-2306184: config refactor - telemetry test update
1 parent b1542c8 commit 2479227

File tree

1 file changed

+30
-35
lines changed

1 file changed

+30
-35
lines changed

tests_integration/nativeapp/test_metrics.py

Lines changed: 30 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414
from shlex import split
15-
from typing import Dict, Callable
15+
from typing import Callable, Dict, List
1616
from unittest import mock
1717

1818
from snowflake.cli._app.telemetry import TelemetryEvent, CLITelemetryField
@@ -111,13 +111,12 @@ def test_feature_counters_v1_post_deploy_set_and_package_scripts_available(
111111
mock_telemetry, TelemetryEvent.CMD_EXECUTION_RESULT.value
112112
)
113113

114-
assert message[CLITelemetryField.COUNTERS.value] == {
115-
CLICounterField.SNOWPARK_PROCESSOR: 0,
116-
CLICounterField.TEMPLATES_PROCESSOR: 0,
117-
CLICounterField.PDF_TEMPLATES: 0,
118-
CLICounterField.POST_DEPLOY_SCRIPTS: 1,
119-
CLICounterField.PACKAGE_SCRIPTS: 0,
120-
}
114+
counters = message[CLITelemetryField.COUNTERS.value]
115+
assert counters[CLICounterField.SNOWPARK_PROCESSOR] == 0
116+
assert counters[CLICounterField.TEMPLATES_PROCESSOR] == 0
117+
assert counters[CLICounterField.PDF_TEMPLATES] == 0
118+
assert counters[CLICounterField.POST_DEPLOY_SCRIPTS] == 1
119+
assert counters[CLICounterField.PACKAGE_SCRIPTS] == 0
121120

122121

123122
@pytest.mark.integration
@@ -161,11 +160,10 @@ def test_feature_counters_v2_post_deploy_not_available_in_bundle(
161160
mock_telemetry, TelemetryEvent.CMD_EXECUTION_RESULT.value
162161
)
163162

164-
assert message[CLITelemetryField.COUNTERS.value] == {
165-
CLICounterField.SNOWPARK_PROCESSOR: 0,
166-
CLICounterField.TEMPLATES_PROCESSOR: 0,
167-
CLICounterField.PDF_TEMPLATES: 1,
168-
}
163+
counters = message[CLITelemetryField.COUNTERS.value]
164+
assert counters[CLICounterField.SNOWPARK_PROCESSOR] == 0
165+
assert counters[CLICounterField.TEMPLATES_PROCESSOR] == 0
166+
assert counters[CLICounterField.PDF_TEMPLATES] == 1
169167

170168

171169
@pytest.mark.integration
@@ -207,15 +205,14 @@ def test_feature_counter_v2_templates_processor_set(
207205
mock_telemetry, TelemetryEvent.CMD_EXECUTION_RESULT.value
208206
)
209207

210-
assert message[CLITelemetryField.COUNTERS.value] == {
211-
CLICounterField.SNOWPARK_PROCESSOR: 0,
212-
CLICounterField.TEMPLATES_PROCESSOR: 1,
213-
CLICounterField.PDF_TEMPLATES: 0,
214-
CLICounterField.POST_DEPLOY_SCRIPTS: 0,
215-
CLICounterField.EVENT_SHARING: 0,
216-
CLICounterField.EVENT_SHARING_ERROR: 0,
217-
CLICounterField.EVENT_SHARING_WARNING: 0,
218-
}
208+
counters = message[CLITelemetryField.COUNTERS.value]
209+
assert counters[CLICounterField.SNOWPARK_PROCESSOR] == 0
210+
assert counters[CLICounterField.TEMPLATES_PROCESSOR] == 1
211+
assert counters[CLICounterField.PDF_TEMPLATES] == 0
212+
assert counters[CLICounterField.POST_DEPLOY_SCRIPTS] == 0
213+
assert counters[CLICounterField.EVENT_SHARING] == 0
214+
assert counters[CLICounterField.EVENT_SHARING_ERROR] == 0
215+
assert counters[CLICounterField.EVENT_SHARING_WARNING] == 0
219216

220217

221218
@pytest.mark.integration
@@ -244,13 +241,12 @@ def test_feature_counter_v1_package_scripts_converted_to_post_deploy_and_both_se
244241
mock_telemetry, TelemetryEvent.CMD_EXECUTION_RESULT.value
245242
)
246243

247-
assert message[CLITelemetryField.COUNTERS.value] == {
248-
CLICounterField.SNOWPARK_PROCESSOR: 0,
249-
CLICounterField.TEMPLATES_PROCESSOR: 0,
250-
CLICounterField.PDF_TEMPLATES: 0,
251-
CLICounterField.POST_DEPLOY_SCRIPTS: 1,
252-
CLICounterField.PACKAGE_SCRIPTS: 1,
253-
}
244+
counters = message[CLITelemetryField.COUNTERS.value]
245+
assert counters[CLICounterField.SNOWPARK_PROCESSOR] == 0
246+
assert counters[CLICounterField.TEMPLATES_PROCESSOR] == 0
247+
assert counters[CLICounterField.PDF_TEMPLATES] == 0
248+
assert counters[CLICounterField.POST_DEPLOY_SCRIPTS] == 1
249+
assert counters[CLICounterField.PACKAGE_SCRIPTS] == 1
254250

255251

256252
@pytest.mark.integration
@@ -289,12 +285,11 @@ def test_feature_counter_v2_post_deploy_set_and_package_scripts_not_available(
289285
mock_telemetry, TelemetryEvent.CMD_EXECUTION_RESULT.value
290286
)
291287

292-
assert message[CLITelemetryField.COUNTERS.value] == {
293-
CLICounterField.SNOWPARK_PROCESSOR: 0,
294-
CLICounterField.TEMPLATES_PROCESSOR: 0,
295-
CLICounterField.PDF_TEMPLATES: 1,
296-
CLICounterField.POST_DEPLOY_SCRIPTS: 1,
297-
}
288+
counters = message[CLITelemetryField.COUNTERS.value]
289+
assert counters[CLICounterField.SNOWPARK_PROCESSOR] == 0
290+
assert counters[CLICounterField.TEMPLATES_PROCESSOR] == 0
291+
assert counters[CLICounterField.PDF_TEMPLATES] == 1
292+
assert counters[CLICounterField.POST_DEPLOY_SCRIPTS] == 1
298293

299294

300295
@pytest.mark.integration

0 commit comments

Comments
 (0)