fix cli for python 3.12 & 3.13 (#2311)

* fix cli for python 3.13

* revert 3.13 to 3.10

* update release notes

* fix: [SNOW-2108648] revert upgrade of supported sf-snowpark-python

* fix: [SNOW-2108648] revert upgrade of supported sf-snowpark-python

Author: sfc-gh-jwilkowski

.github/workflows/matrix.yaml

@@ -30,7 +30,7 @@ jobs:
         id: python
         run: |
           if [ "${{ github.event_name }}" = "schedule" ]; then
-            echo 'python=["3.10", "3.11", "3.12"]' >> "$GITHUB_OUTPUT"
+            echo 'python=["3.10", "3.11", "3.12", "3.13"]' >> "$GITHUB_OUTPUT"
           else
             # Last supported and most frequently used
             echo 'python=["3.10"]' >> "$GITHUB_OUTPUT"

RELEASE-NOTES.md

@@ -24,6 +24,7 @@
 
 ## Fixes and improvements
 * Upgrade message is printed to stderr.
+* Fixed `snowflake.core` import issue on newer Python versions
 
 # v3.8.0
 

pyproject.toml

@@ -40,7 +40,7 @@ dependencies = [
   "setuptools==80.3.1",
   "snowflake-connector-python[secure-local-storage]==3.15.0",
   'snowflake-snowpark-python>=1.15.0,<1.26.0;python_version < "3.12"',
-  'snowflake.core==1.4.0; python_version < "3.12"',
+  "snowflake.core==1.4.0",
   "tomlkit==0.13.2",
   "typer==0.15.2",
   "urllib3>=1.24.3,<2.5",
@@ -155,7 +155,7 @@ test_qa = [
 ]
 
 [[tool.hatch.envs.local.matrix]]
-python = ["3.10", "3.11", "3.12"]
+python = ["3.10", "3.11", "3.12", "3.13"]
 
 [tool.coverage.run]
 source = ["snowflake.cli"]

snyk/requirements.txt

@@ -13,7 +13,7 @@ rich==14.0.0
 setuptools==80.3.1
 snowflake-connector-python[secure-local-storage]==3.15.0
 snowflake-snowpark-python>=1.15.0,<1.26.0;python_version < "3.12"
-snowflake.core==1.4.0; python_version < "3.12"
+snowflake.core==1.4.0
 tomlkit==0.13.2
 typer==0.15.2
 urllib3>=1.24.3,<2.5

tests/nativeapp/codegen/test_sandbox.py

@@ -19,7 +19,7 @@
 import pytest
 import snowflake.cli._plugins.nativeapp.codegen.sandbox as sandbox
 
-from tests_common import IS_WINDOWS
+from tests_common import IS_WINDOWS, skip_snowpark_on_newest_python
 
 PYTHON_SCRIPT = """
 import sys
@@ -825,6 +825,7 @@ def test_execute_does_not_interpret_return_codes(
     assert not mock_which.called
 
 
+@skip_snowpark_on_newest_python
 def test_sandbox_env_builder(temporary_directory):
     env_path = Path(temporary_directory) / "venv"
     builder = sandbox.SandboxEnvBuilder(env_path)

tests_common/conftest.py

@@ -28,6 +28,7 @@
 from snowflake.cli._plugins.streamlit.streamlit_entity_model import StreamlitEntityModel
 from snowflake.cli._plugins.workspace.context import WorkspaceContext, ActionContext
 from snowflake.cli.api.console.abc import AbstractConsole
+from snowflake.cli.api.constants import PYTHON_3_12
 
 PROJECT_DIR = Path(__file__).parent / "test_data" / "projects"
 
@@ -131,3 +132,9 @@ def _update(snowflake_yml_path: Path, parameter_path: str, value=None):
             yaml.safe_dump(yml, fh)
 
     return _update
+
+
+skip_snowpark_on_newest_python = pytest.mark.skipif(
+    sys.version_info >= PYTHON_3_12,
+    reason="requires python3.11 or lower",
+)

tests_e2e/conftest.py

@@ -22,6 +22,7 @@
 
 import pytest
 from snowflake.cli import __about__
+from snowflake.cli.api.constants import PYTHON_3_12
 from snowflake.cli.api.secure_path import SecurePath
 
 from tests_common import IS_WINDOWS
@@ -143,8 +144,8 @@ def _install_snowcli_with_external_plugin(
         / "multilingual_hello_command_group",
     )
 
-    # Required by snowpark example tests
-    _pip_install(python, "snowflake-snowpark-python[pandas]==1.25.0")
+    if sys.version_info < PYTHON_3_12:
+        _pip_install(python, "snowflake-snowpark-python[pandas]==1.25.0")
 
 
 def _python_path(venv_path: Path) -> Path:

tests_e2e/test_installation.py

@@ -11,21 +11,23 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
 from pathlib import Path
 
 import pytest
 
+from tests_common import skip_snowpark_on_newest_python
 from tests_e2e.conftest import subprocess_check_output, subprocess_run
 
 
 @pytest.mark.e2e
+@skip_snowpark_on_newest_python
 def test_snow_help(snowcli, snapshot):
     output = subprocess_check_output([snowcli, "--help"])
     snapshot.assert_match(output)
 
 
 @pytest.mark.e2e
+@skip_snowpark_on_newest_python
 def test_snow_sql(snowcli, test_root_path, snapshot):
     output = subprocess_check_output(
         [

tests_e2e/test_nativeapp.py

@@ -19,6 +19,7 @@
 
 import pytest
 
+from tests_common import skip_snowpark_on_newest_python
 from tests_e2e.conftest import subprocess_check_output, subprocess_run
 
 
@@ -68,6 +69,7 @@ def assert_snapshot_match_with_query_result(output: str, snapshot) -> bool:
 
 
 @pytest.mark.e2e
+@skip_snowpark_on_newest_python
 def test_full_lifecycle_with_codegen(
     snowcli, test_root_path, project_directory, snapshot
 ):

tests_integration/nativeapp/test_bundle.py

@@ -15,11 +15,11 @@
 import os
 import os.path
 
-import pytest
 import yaml
 from shlex import split
 
 from tests.project.fixtures import *
+from tests_common import skip_snowpark_on_newest_python
 from tests_integration.testing_utils import (
     assert_that_result_failed_with_message_containing,
 )
@@ -344,6 +344,7 @@ def test_nativeapp_can_bundle_with_subdirs(
 
 
 @pytest.mark.integration
+@skip_snowpark_on_newest_python
 def test_nativeapp_bundle_subdirs_dont_overwrite(
     runner, nativeapp_teardown, setup_v2_project_w_subdir_w_snowpark
 ):