Skip to content

Commit 43caa83

Browse files
committed
SNOW-2306184: config refactor - e2e fix attempt 5b
1 parent 62ccf83 commit 43caa83

File tree

2 files changed

+5
-24
lines changed

2 files changed

+5
-24
lines changed

tests_e2e/__snapshots__/test_import_snowsql_connections.ambr

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
# serializer version: 1
2-
# name: test_import_confirm_on_conflict_with_existing_cli_connection
3-
'[{"connection_name": "example", "parameters": {"user": "u1", "schema": "public", "authenticator": "SNOWFLAKE_JWT"}, "is_default": false}]'
4-
# ---
5-
# name: test_import_confirm_on_conflict_with_existing_cli_connection.1
6-
'[{"connection_name": "example", "parameters": {"account": "accountname", "user": "username"}, "is_default": false}, {"connection_name": "snowsql1", "parameters": {"account": "a1", "user": "u1", "host": "h1_override", "database": "d1", "schema": "public", "warehouse": "w1", "role": "r1"}, "is_default": false}, {"connection_name": "snowsql2", "parameters": {"account": "a2", "user": "u2", "host": "h2", "port": 1234, "database": "d2", "schema": "public", "warehouse": "w2", "role": "r2"}, "is_default": false}, {"connection_name": "snowsql3", "parameters": {"account": "a3", "user": "u3", "password": "****", "host": "h3", "database": "d3", "schema": "public", "warehouse": "w3", "role": "r3"}, "is_default": false}, {"connection_name": "default", "parameters": {"account": "default_connection_account", "user": "default_connection_user", "host": "localhost", "database": "default_connection_database_override", "schema": "public", "warehouse": "default_connection_warehouse", "role": "accountadmin"}, "is_default": true}]'
7-
# ---
82
# name: test_import_confirm_on_conflict_with_existing_cli_connection[config_ng]
93
'''
104
[
@@ -197,12 +191,6 @@
197191
]
198192
'''
199193
# ---
200-
# name: test_import_of_snowsql_connections
201-
'[]'
202-
# ---
203-
# name: test_import_of_snowsql_connections.1
204-
'[{"connection_name": "snowsql1", "parameters": {"account": "a1", "user": "u1", "host": "h1_override", "database": "d1", "schema": "public", "warehouse": "w1", "role": "r1"}, "is_default": false}, {"connection_name": "snowsql2", "parameters": {"account": "a2", "user": "u2", "host": "h2", "port": 1234, "database": "d2", "schema": "public", "warehouse": "w2", "role": "r2"}, "is_default": false}, {"connection_name": "example", "parameters": {"account": "accountname", "user": "username"}, "is_default": false}, {"connection_name": "snowsql3", "parameters": {"account": "a3", "user": "u3", "password": "****", "host": "h3", "database": "d3", "schema": "public", "warehouse": "w3", "role": "r3"}, "is_default": false}, {"connection_name": "default", "parameters": {"account": "default_connection_account", "user": "default_connection_user", "host": "localhost", "database": "default_connection_database_override", "schema": "public", "warehouse": "default_connection_warehouse", "role": "accountadmin"}, "is_default": true}]'
205-
# ---
206194
# name: test_import_of_snowsql_connections[config_ng]
207195
'''
208196
[
@@ -374,12 +362,6 @@
374362
]
375363
'''
376364
# ---
377-
# name: test_import_prompt_for_different_default_connection_name_on_conflict
378-
'[]'
379-
# ---
380-
# name: test_import_prompt_for_different_default_connection_name_on_conflict.1
381-
'[{"connection_name": "snowsql1", "parameters": {"account": "a1", "user": "u1", "host": "h1_override", "database": "d1", "schema": "public", "warehouse": "w1", "role": "r1"}, "is_default": false}, {"connection_name": "snowsql2", "parameters": {"account": "a2", "user": "u2", "host": "h2", "port": 1234, "database": "d2", "schema": "public", "warehouse": "w2", "role": "r2"}, "is_default": true}, {"connection_name": "example", "parameters": {"account": "accountname", "user": "username"}, "is_default": false}, {"connection_name": "snowsql3", "parameters": {"account": "a3", "user": "u3", "password": "****", "host": "h3", "database": "d3", "schema": "public", "warehouse": "w3", "role": "r3"}, "is_default": false}, {"connection_name": "default", "parameters": {"account": "default_connection_account", "user": "default_connection_user", "host": "localhost", "database": "default_connection_database_override", "schema": "public", "warehouse": "default_connection_warehouse", "role": "accountadmin"}, "is_default": false}]'
382-
# ---
383365
# name: test_import_prompt_for_different_default_connection_name_on_conflict[config_ng]
384366
'''
385367
[
@@ -551,12 +533,6 @@
551533
]
552534
'''
553535
# ---
554-
# name: test_import_reject_on_conflict_with_existing_cli_connection
555-
'[{"connection_name": "example", "parameters": {"user": "u1", "schema": "public", "authenticator": "SNOWFLAKE_JWT"}, "is_default": false}]'
556-
# ---
557-
# name: test_import_reject_on_conflict_with_existing_cli_connection.1
558-
'[{"connection_name": "example", "parameters": {"user": "u1", "schema": "public", "authenticator": "SNOWFLAKE_JWT"}, "is_default": false}, {"connection_name": "snowsql1", "parameters": {"account": "a1", "user": "u1", "host": "h1_override", "database": "d1", "schema": "public", "warehouse": "w1", "role": "r1"}, "is_default": false}, {"connection_name": "snowsql2", "parameters": {"account": "a2", "user": "u2", "host": "h2", "port": 1234, "database": "d2", "schema": "public", "warehouse": "w2", "role": "r2"}, "is_default": false}, {"connection_name": "snowsql3", "parameters": {"account": "a3", "user": "u3", "password": "****", "host": "h3", "database": "d3", "schema": "public", "warehouse": "w3", "role": "r3"}, "is_default": false}, {"connection_name": "default", "parameters": {"account": "default_connection_account", "user": "default_connection_user", "host": "localhost", "database": "default_connection_database_override", "schema": "public", "warehouse": "default_connection_warehouse", "role": "accountadmin"}, "is_default": true}]'
559-
# ---
560536
# name: test_import_reject_on_conflict_with_existing_cli_connection[config_ng]
561537
'''
562538
[

tests_e2e/test_import_snowsql_connections.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,10 @@ def test_connection_imported_from_snowsql(
166166
snowcli, test_root_path, empty_config_file, config_mode
167167
):
168168
"""Test that imported connection works."""
169+
# In config_ng, an INTEGRATION connection may already exist via env vars.
170+
# Confirm override explicitly to avoid interactive abort.
171+
stdin = "y\n" if config_mode == "config_ng" else None
172+
169173
result = subprocess_run(
170174
[
171175
snowcli,
@@ -176,6 +180,7 @@ def test_connection_imported_from_snowsql(
176180
"--snowsql-config-file",
177181
test_root_path / "config" / "snowsql" / "integration_config",
178182
],
183+
stdin=stdin,
179184
)
180185
assert result.returncode == 0
181186

0 commit comments

Comments
 (0)