Skip to content

Commit 4635b8a

Browse files
Fix integration test: remove explicit database/schema flags, rely on test_database fixture env var
1 parent a31d6ce commit 4635b8a

File tree

1 file changed

+3
-34
lines changed

1 file changed

+3
-34
lines changed

tests_integration/test_streamlit_old.py

Lines changed: 3 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -141,17 +141,7 @@ def _assert_file_names_on_stage(expected_files: List[str]) -> None:
141141
with project_directory(f"streamlit_v2") as project_root:
142142
# deploy streamlit with legacy flag to use ROOT_LOCATION stages
143143
result = runner.invoke_with_connection(
144-
[
145-
"streamlit",
146-
"deploy",
147-
"my_streamlit",
148-
"--replace",
149-
"--legacy",
150-
"--database",
151-
test_database,
152-
"--schema",
153-
"public",
154-
]
144+
["streamlit", "deploy", "my_streamlit", "--replace", "--legacy"]
155145
)
156146
assert result.exit_code == 0, result.output
157147
_assert_file_names_on_stage(["streamlit_app.py"])
@@ -172,17 +162,7 @@ def _assert_file_names_on_stage(expected_files: List[str]) -> None:
172162

173163
# deploy streamlit again without prune - unexpected file should remain on stage
174164
result = runner.invoke_with_connection(
175-
[
176-
"streamlit",
177-
"deploy",
178-
"my_streamlit",
179-
"--replace",
180-
"--legacy",
181-
"--database",
182-
test_database,
183-
"--schema",
184-
"public",
185-
]
165+
["streamlit", "deploy", "my_streamlit", "--replace", "--legacy"]
186166
)
187167
assert result.exit_code == 0, result.output
188168
_assert_file_names_on_stage(
@@ -194,18 +174,7 @@ def _assert_file_names_on_stage(expected_files: List[str]) -> None:
194174

195175
# deploy with --prune flag - unexpected file should be removed
196176
result = runner.invoke_with_connection(
197-
[
198-
"streamlit",
199-
"deploy",
200-
"my_streamlit",
201-
"--replace",
202-
"--legacy",
203-
"--prune",
204-
"--database",
205-
test_database,
206-
"--schema",
207-
"public",
208-
]
177+
["streamlit", "deploy", "my_streamlit", "--replace", "--legacy", "--prune"]
209178
)
210179
assert result.exit_code == 0, result.output
211180
_assert_file_names_on_stage(["streamlit_app.py"])

0 commit comments

Comments
 (0)