feat: [SNOW-988145] provide connection name as arg (#2528)

Author: sfc-gh-jwilkowski

src/snowflake/cli/_plugins/connection/commands.py

@@ -319,12 +319,9 @@ def add(
     )
 
 
-@app.command()
+@app.command(requires_connection=False)
 def remove(
-    connection_name: str = typer.Option(
-        None,
-        "--connection-name",
-        "-n",
+    connection_name: str = typer.Argument(
         help="Name of the connection to remove.",
         show_default=False,
     ),

tests/__snapshots__/test_help_messages.ambr

@@ -5129,14 +5129,17 @@
 # name: test_help_messages[connection.remove]
   '''
 
-   Usage: root connection remove [OPTIONS]                                        
+   Usage: root connection remove [OPTIONS] CONNECTION_NAME                        
 
    Removes a connection from configuration file.                                  
 
 
+  +- Arguments ------------------------------------------------------------------+
+  | *    connection_name      TEXT  Name of the connection to remove.            |
+  |                                 [required]                                   |
+  +------------------------------------------------------------------------------+
   +- Options --------------------------------------------------------------------+
-  | --connection-name  -n      TEXT  Name of the connection to remove.           |
-  | --help             -h            Show this message and exit.                 |
+  | --help  -h        Show this message and exit.                                |
   +------------------------------------------------------------------------------+
   +- Global configuration -------------------------------------------------------+
   | --format                       [TABLE|JSON|JSON_EXT|  Specifies the output   |

tests/test_connection.py

@@ -1776,7 +1776,7 @@ def _add_connection(runner, tmp_file, name, is_default=False, expected_to_fail=F
 
 def _remove_connection(runner, tmp_file, name, expected_to_fail=False):
     result = runner.invoke_with_config_file(
-        tmp_file.name, ["connection", "remove", "--connection-name", name]
+        tmp_file.name, ["connection", "remove", name]
     )
     if expected_to_fail:
         assert result.exit_code != 0, result.output