Fix unit tests for versioned Streamlit deployment

- Add mock for describe() method to return versioned stage path
- Update test_deploy to use legacy=True for testing old behavior
- Replace experimental parameter with legacy parameter in SPCS runtime v2 tests
- Fix test_deploy_with_spcs_runtime_v2_and_legacy_flag_raises_error invalid parameters

Changes reflect that versioned deployment is now the default, and the
experimental flag has been replaced with a legacy flag to opt into old behavior.

Author: sfc-gh-svishnu

tests/streamlit/streamlit_test_class.py

@@ -53,6 +53,16 @@ def setup_method(self):
             lambda _, **kwargs: False,
         ).start()
 
+        # Mock describe() to return a versioned stage path for versioned deployments
+        self.mock_describe = mock.patch(
+            "snowflake.cli._plugins.streamlit.streamlit_entity.StreamlitEntity.describe"
+        ).start()
+        mock_cursor = mock.Mock()
+        mock_cursor.fetchone.return_value = {
+            "live_version_location_uri": f"snow://streamlit/DB.PUBLIC.{STREAMLIT_NAME}/versions/live/"
+        }
+        self.mock_describe.return_value = mock_cursor
+
     def teardown_method(self):
         mock.patch.stopall()
 

tests/streamlit/test_streamlit_entity.py

@@ -55,7 +55,10 @@ def test_deploy(self, mock_get_url, mock_describe, example_entity, action_contex
         mock_describe.return_value = False
         mock_get_url.return_value = "https://snowflake.com"
 
-        example_entity.action_deploy(action_context, _open=False, replace=False)
+        # Test legacy deployment behavior
+        example_entity.action_deploy(
+            action_context, _open=False, replace=False, legacy=True
+        )
 
         self.mock_execute.assert_called_with(
             f"CREATE STREAMLIT IDENTIFIER('{STREAMLIT_NAME}')\nROOT_LOCATION = '@streamlit/test_streamlit'\nMAIN_FILE = 'streamlit_app.py'\nQUERY_WAREHOUSE = test_warehouse\nTITLE = 'My Fancy Streamlit';"
@@ -149,10 +152,8 @@ def test_get_deploy_sql_with_spcs_runtime_v2(self, workspace_context):
 
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
 
-        # Test with FROM syntax (artifacts_dir provided)
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=True
-        )
+        # Test with FROM syntax (artifacts_dir provided) - versioned deployment
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=False)
 
         assert f"RUNTIME_NAME = '{SPCS_RUNTIME_V2_NAME}'" in sql
         assert "COMPUTE_POOL = 'MYPOOL'" in sql
@@ -172,16 +173,16 @@ def test_get_deploy_sql_spcs_runtime_v2_with_stage(self, workspace_context):
 
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
 
-        # Test with stage-based deployment - should NOT include SPCS runtime fields
-        # even when experimental=True, as stage-based deployments are old-style
-        sql = entity.get_deploy_sql(from_stage_name="@stage/path", experimental=True)
+        # Test with stage-based deployment (ROOT_LOCATION) - should NOT include SPCS runtime fields
+        # as stage-based deployments are old-style
+        sql = entity.get_deploy_sql(from_stage_name="@stage/path", legacy=False)
 
         assert "ROOT_LOCATION = '@stage/path'" in sql
         assert "RUNTIME_NAME" not in sql
         assert "COMPUTE_POOL" not in sql
 
     def test_get_deploy_sql_without_spcs_runtime_v2(self, workspace_context):
-        """Test that get_deploy_sql works normally when experimental is False"""
+        """Test that get_deploy_sql works normally when legacy is True"""
         model = StreamlitEntityModel(
             type="streamlit",
             identifier="test_streamlit",
@@ -194,10 +195,8 @@ def test_get_deploy_sql_without_spcs_runtime_v2(self, workspace_context):
 
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
 
-        # Test without experimental flag enabled
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=False
-        )
+        # Test with legacy flag - should not add SPCS runtime v2 fields
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=True)
 
         assert "RUNTIME_NAME" not in sql
         assert "COMPUTE_POOL" not in sql
@@ -216,26 +215,20 @@ def test_spcs_runtime_v2_requires_correct_runtime_name(self, workspace_context):
 
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
 
-        # Test with experimental=True and correct runtime_name
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=True
-        )
+        # Test with versioned deployment (default, legacy=False) and correct runtime_name
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=False)
         assert f"RUNTIME_NAME = '{SPCS_RUNTIME_V2_NAME}'" in sql
         assert "COMPUTE_POOL = 'MYPOOL'" in sql
 
-        # Test with experimental=False, should not add SPCS fields
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=False
-        )
+        # Test with legacy=True, should not add SPCS fields
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=True)
         assert "RUNTIME_NAME" not in sql
         assert "COMPUTE_POOL" not in sql
 
         # Test with wrong runtime_name
         model.runtime_name = "SOME_OTHER_RUNTIME"
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=True
-        )
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=False)
         assert "RUNTIME_NAME" not in sql
         assert "COMPUTE_POOL" not in sql
 
@@ -253,9 +246,7 @@ def test_spcs_runtime_v2_requires_runtime_and_pool(self, workspace_context):
         )
         model.set_entity_id("test_streamlit")
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=True
-        )
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=False)
         assert f"RUNTIME_NAME = '{SPCS_RUNTIME_V2_NAME}'" in sql
         assert "COMPUTE_POOL = 'MYPOOL'" in sql
 
@@ -269,9 +260,7 @@ def test_spcs_runtime_v2_requires_runtime_and_pool(self, workspace_context):
         )
         model.set_entity_id("test_streamlit")
         entity = StreamlitEntity(workspace_ctx=workspace_context, entity_model=model)
-        sql = entity.get_deploy_sql(
-            artifacts_dir=Path("/tmp/artifacts"), experimental=True
-        )
+        sql = entity.get_deploy_sql(artifacts_dir=Path("/tmp/artifacts"), legacy=False)
         # Warehouse runtime should not trigger SPCS runtime v2 mode
         assert "RUNTIME_NAME" not in sql
         assert "COMPUTE_POOL" not in sql
@@ -347,12 +336,11 @@ def test_deploy_with_spcs_runtime_v2_and_legacy_flag_raises_error(
             main_file="streamlit_app.py",
             artifacts=["streamlit_app.py"],
         )
+        model.set_entity_id("test_streamlit")
 
         entity = StreamlitEntity(
             workspace_ctx=workspace_context,
             entity_model=model,
-            project_root=Path(__file__).parent / "test_data" / "projects",
-            entity_id="test_streamlit",
         )
 
         with pytest.raises(