Skip to content

Commit 693de06

Browse files
SNOW-2347459 Revert to default precision not to introduce BCR (#2617)
1 parent a31a1a5 commit 693de06

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

RELEASE-NOTES.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
* Improved output handling with streaming
4242
* Bumped `snowflake-connector-python` to 3.17.3
4343
* Fixed `snow snowpark deploy` failing on duplicated packages
44-
* Extend `Decimal` precision to 38
4544

4645

4746
# v3.11.0

src/snowflake/cli/_app/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import decimal
1615
import logging
1716
import os
1817

@@ -21,6 +20,3 @@
2120

2221
# Restrict permissions of all created files
2322
os.umask(0o077)
24-
25-
# Set Decimal precision to reflect precision on Snowflake
26-
decimal.getcontext().prec = 38

tests_integration/sql/test_sql.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,10 +371,10 @@ def test_decfloat_values(runner):
371371
row = result.json[0]
372372

373373
# Assert exact values that Snowflake returns for DECFLOAT
374-
assert row["POSITIVE_VALUE"] == "123456789012345678901234567890.12345679"
375-
assert row["NEGATIVE_VALUE"] == "-123456789012345678901234567890.12345679"
374+
assert row["POSITIVE_VALUE"] == "1.234567890123456789012345679E+29"
375+
assert row["NEGATIVE_VALUE"] == "-1.234567890123456789012345679E+29"
376376
assert (
377-
row["FLOATING_POINT"] == "3.1415926535897932384626433832795028842"
378-
) # value is rounded up to 38 numbers
379-
assert row["MAXIMUM_VALUE"] == "9.9999999999999999999999999999999999999E+16421"
380-
assert row["MINIMUM_VALUE"] == "-9.9999999999999999999999999999999999999E+16421"
377+
row["FLOATING_POINT"] == "3.141592653589793238462643383"
378+
) # value is rounded up to 28 numbers
379+
assert row["MAXIMUM_VALUE"] == "1.000000000000000000000000000E+16422"
380+
assert row["MINIMUM_VALUE"] == "-1.000000000000000000000000000E+16422"

0 commit comments

Comments
 (0)