Skip to content

Commit 842d693

Browse files
committed
SNOW-2306184: ms fixes p2
1 parent 905e7cc commit 842d693

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

tests/spcs/test_services.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,23 @@
6868

6969
@pytest.fixture()
7070
def enable_events_and_metrics_config():
71+
from snowflake.cli.api.utils.path_utils import path_resolver
72+
from tests.conftest import clean_logging_handlers
73+
7174
with TemporaryDirectory() as tempdir:
72-
config_toml = Path(tempdir) / "config.toml"
75+
# Resolve Windows short paths to prevent cleanup issues
76+
resolved_tempdir = path_resolver(tempdir)
77+
config_toml = Path(resolved_tempdir) / "config.toml"
7378
config_toml.write_text(
7479
"[cli.features]\n"
7580
"enable_spcs_service_events = true\n"
7681
"enable_spcs_service_metrics = true\n"
7782
)
78-
yield config_toml
83+
try:
84+
yield config_toml
85+
finally:
86+
# Ensure all logging handlers are closed before temp directory cleanup
87+
clean_logging_handlers()
7988

8089

8190
@patch(EXECUTE_QUERY)

0 commit comments

Comments
 (0)