Snow 2106457 fix queries time filter timing out (#2297)

* convert timestamp to integer

* integration tests

* fix unit tests

* fix integration tests

Author: sfc-gh-pczajka

src/snowflake/cli/_plugins/sql/snowsql_commands.py

@@ -52,8 +52,8 @@ class QueriesCommand(SnowSQLCommand):
     amount: int = 25
     user: str | None = None
     warehouse: str | None = None
-    start_timestamp_ms: float | None = None
-    end_timestamp_ms: float | None = None
+    start_timestamp_ms: int | None = None
+    end_timestamp_ms: int | None = None
     duration: str | None = None
     stmt_type: str | None = None
     status: str | None = None
@@ -81,8 +81,8 @@ def _execute_help(self):
                 "datetime in ISO format (for example YYYY-MM-DDTHH:mm:ss.sss)",
                 "any",
             ],
-            ["start", "timestamp in milliseconds", "any"],
-            ["end", "timestamp in milliseconds", "any"],
+            ["start", "timestamp in milliseconds (integer)", "any"],
+            ["end", "timestamp in milliseconds (integer)", "any"],
             ["type", "string", "any"],
             ["duration", "time in milliseconds", "any"],
             ["session", "No arguments", "any"],
@@ -147,15 +147,15 @@ def from_args(cls, args: List[str], kwargs: Dict[str, Any]) -> CompileCommandRes
         start_timestamp_ms = kwargs.pop("start", None)
         if start_timestamp_ms:
             try:
-                start_timestamp_ms = float(start_timestamp_ms)
+                start_timestamp_ms = int(start_timestamp_ms)
             except ValueError:
                 return CompileCommandResult(
                     error_message=f"Invalid argument passed to 'start' filter: {start_timestamp_ms}"
                 )
         end_timestamp_ms = kwargs.pop("end", None)
         if end_timestamp_ms:
             try:
-                end_timestamp_ms = float(end_timestamp_ms)
+                end_timestamp_ms = int(end_timestamp_ms)
             except ValueError:
                 return CompileCommandResult(
                     error_message=f"Invalid argument passed to 'end' filter: {end_timestamp_ms}"
@@ -169,7 +169,7 @@ def from_args(cls, args: List[str], kwargs: Dict[str, Any]) -> CompileCommandRes
                 )
             try:
                 seconds = datetime.fromisoformat(start_date).timestamp()
-                start_timestamp_ms = seconds * 1000  # convert to milliseconds
+                start_timestamp_ms = int(seconds * 1000)  # convert to milliseconds
             except ValueError:
                 return CompileCommandResult(
                     error_message=f"Invalid date format passed to 'start_date' filter: {start_date}"
@@ -182,7 +182,7 @@ def from_args(cls, args: List[str], kwargs: Dict[str, Any]) -> CompileCommandRes
                 )
             try:
                 seconds = datetime.fromisoformat(end_date).timestamp()
-                end_timestamp_ms = seconds * 1000  # convert to milliseconds
+                end_timestamp_ms = int(seconds * 1000)  # convert to milliseconds
             except ValueError:
                 return CompileCommandResult(
                     error_message=f"Invalid date format passed to 'end_date' filter: {end_date}"

tests/sql/test_snowsql_commands.py

@@ -119,8 +119,8 @@ def test_queries_from_args():
                 amount=3,
                 user="user",
                 warehouse="warehouse",
-                start_timestamp_ms=1234.0,
-                end_timestamp_ms=5678.0,
+                start_timestamp_ms=1234,
+                end_timestamp_ms=5678,
                 duration="200",
                 stmt_type="INSERT",
                 status="RUNNING",
@@ -137,7 +137,7 @@ def test_queries_from_args():
         },
     ) == CompileCommandResult(
         command=QueriesCommand(
-            start_timestamp_ms=1746403200000.0, end_timestamp_ms=1746403201000.0
+            start_timestamp_ms=1746403200000, end_timestamp_ms=1746403201000
         )
     )
 
@@ -248,16 +248,16 @@ def test_queries_execute(mock_print, mock_time, mock_ctx, current_session):
         amount=3,
         user="user",
         warehouse="warehouse",
-        start_timestamp_ms=2345.0,
-        end_timestamp_ms=6789.0,
+        start_timestamp_ms=2345,
+        end_timestamp_ms=6789,
         duration="200",
         stmt_type="INSERT",
         status="RUNNING",
     ).execute(ctx)
 
     expected_url = (
         "/monitoring/queries?_dc=mocked_time&includeDDL=false&max=3&user=user&wh=warehouse"
-        "&start=2345.0&end=6789.0&min_duration=200"
+        "&start=2345&end=6789&min_duration=200"
         f"{'&session_id=mocked_session_id' if current_session else ''}"
         "&subset=RUNNING&stmt_type=INSERT"
     )

tests_integration/sql/__snapshots__/test_snowsql_commands.ambr

@@ -12,8 +12,8 @@
   |            | YYYY-MM-DDTHH:mm:ss.sss)                              |         |
   | end_date   | datetime in ISO format (for example                   | any     |
   |            | YYYY-MM-DDTHH:mm:ss.sss)                              |         |
-  | start      | timestamp in milliseconds                             | any     |
-  | end        | timestamp in milliseconds                             | any     |
+  | start      | timestamp in milliseconds (integer)                   | any     |
+  | end        | timestamp in milliseconds (integer)                   | any     |
   | type       | string                                                | any     |
   | duration   | time in milliseconds                                  | any     |
   | session    | No arguments                                          | any     |