Skip to content

Commit aab77a7

Browse files
Fix integration test after Snowflake rollout (#2155)
1 parent 5094954 commit aab77a7

File tree

1 file changed

+1
-29
lines changed

1 file changed

+1
-29
lines changed

tests_integration/test_notebooks.py

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,8 @@ def test_containerized_notebook(runner, project_directory, test_database):
9393
assert "unschedulable in full compute pool." in result.output
9494

9595

96-
@pytest.mark.qa_only
9796
@pytest.mark.integration
98-
def test_containerized_notebook_incorrect_runtime_error_qa(
97+
def test_containerized_notebook_incorrect_runtime_error(
9998
runner, project_directory, test_database, alter_snowflake_yml
10099
):
101100
notebook_identifier = "containerized_notebook"
@@ -112,30 +111,3 @@ def test_containerized_notebook_incorrect_runtime_error_qa(
112111
"invalid value 'NOT_EXISTING_RUNTIME_NAME' for property 'RUNTIME_NAME'"
113112
in result.output
114113
)
115-
116-
117-
@pytest.mark.no_qa
118-
@pytest.mark.integration
119-
def test_containerized_notebook_incorrect_runtime_error(
120-
runner, project_directory, test_database, alter_snowflake_yml
121-
):
122-
notebook_identifier = "containerized_notebook"
123-
with project_directory("notebook_containerized_v2") as project_directory:
124-
alter_snowflake_yml(
125-
project_directory / "snowflake.yml",
126-
f"entities.{notebook_identifier}.runtime_name",
127-
"not_existing_runtime_name",
128-
)
129-
result = runner.invoke_with_connection(["notebook", "deploy"])
130-
assert result.exit_code == 0, (
131-
"If this test fails here on github integration tests, "
132-
"remove this test and remove '@qa_only' mark from the test above"
133-
)
134-
135-
# readable error message should be returned when trying to execute the notebook
136-
result = runner.invoke_with_connection(
137-
["notebook", "execute", notebook_identifier]
138-
)
139-
assert result.exit_code == 1, result.output
140-
assert "Custom runtime" in result.output
141-
assert "runtimeName=NOT_EXISTING_RUNTIME_NAME is not supported" in result.output

0 commit comments

Comments
 (0)