SNOW-2306184: remove useless comments

Author: sfc-gh-mraba

src/snowflake/cli/api/cli_global_context.py

@@ -67,7 +67,6 @@ class _CliGlobalContextManager:
     _definition_manager: DefinitionManager | None = None
     enhanced_exit_codes: bool = False
 
-    # Configuration management
     _config_manager: ConfigManager | None = None
     config_file_override: Path | None = None
     connections_file_override: Path | None = None
@@ -79,7 +78,6 @@ class _CliGlobalContextManager:
         "project_env_overrides_args",
     ]
 
-    # Dependencies that invalidate config manager
     CONFIG_MANAGER_DEPENDENCIES = ["config_file_override", "connections_file_override"]
 
     def reset(self):
@@ -180,24 +178,20 @@ def _create_config_manager(self) -> ConfigManager:
         )
         from snowflake.connector.constants import CONFIG_FILE
 
-        # Get current connections file path (handles test env changes)
         connections_file = get_connections_file()
 
-        # Create ConfigSlice for connections.toml (same as singleton CONFIG_MANAGER)
         connections_slice = ConfigSlice(
             path=connections_file,
             options=ConfigSliceOptions(check_permissions=True, only_in_slice=False),
             section="connections",
         )
 
-        # Create manager instance with connections slice
         manager = ConfigManager(
             name="CONFIG_MANAGER",
             file_path=self.config_file_override or CONFIG_FILE,
             _slices=[connections_slice],
         )
 
-        # Add connector's default options (replicating connector's singleton setup)
         manager.add_option(
             name="connections",
             parse_str=tomlkit.parse,
@@ -208,7 +202,6 @@ def _create_config_manager(self) -> ConfigManager:
             name="default_connection_name", parse_str=str, default="default"
         )
 
-        # Add CLI-specific options (current lines 66-70 in config.py)
         from snowflake.cli.api.config import CLI_SECTION
 
         manager.add_option(

src/snowflake/cli/api/config.py

@@ -82,8 +82,6 @@ class Empty:
 PLUGIN_ENABLED_KEY = "enabled"
 FEATURE_FLAGS_SECTION_PATH = [CLI_SECTION, "features"]
 
-# CLI_SECTION option registration now handled in CLI context manager
-
 
 @dataclass
 class ConnectionConfig:
@@ -150,7 +148,6 @@ def config_init(config_file: Optional[Path]):
     from snowflake.cli._app.loggers import create_initial_loggers
     from snowflake.cli.api.cli_global_context import get_cli_context_manager
 
-    # Set config file override in context instead of direct assignment
     if config_file:
         get_cli_context_manager().config_file_override = config_file
     else:
@@ -199,7 +196,6 @@ def _get_default_logs_config() -> dict:
     from snowflake.cli.api.utils.path_utils import path_resolver
 
     config_parent_path = get_config_manager().file_path.parent
-    # Resolve Windows short paths to prevent issues with temp directory cleanup
     resolved_parent_path = path_resolver(str(config_parent_path))
 
     return {

tests/conftest.py

@@ -114,10 +114,9 @@ def reset_global_context_and_setup_config_and_logging_levels(
         cli_context_manager.enable_tracebacks = False
         cli_context_manager.connection_cache = connection_cache
 
-        # Set config file override in context for test isolation
         cli_context_manager.config_file_override = test_snowcli_config
 
-        config_init(None)  # No need to pass config file, it's in context
+        config_init(None)
         loggers.create_loggers(verbose=False, debug=False)
         try:
             yield
@@ -238,7 +237,6 @@ def app_zip(temporary_directory) -> Generator:
     yield create_temp_file(".zip", temporary_directory, [])
 
 
-# New fixtures for config manager testing
 @pytest.fixture
 def config_manager():
     """
@@ -325,7 +323,6 @@ def _create_manager(
 
     yield _create_manager
 
-    # Cleanup
     for file in created_files:
         file.unlink(missing_ok=True)
 
@@ -519,7 +516,6 @@ def func():
 @contextmanager
 def _named_temporary_file(suffix=None, prefix=None):
     with tempfile.TemporaryDirectory() as tmp_dir:
-        # Resolve Windows short paths to prevent cleanup issues
         from snowflake.cli.api.utils.path_utils import path_resolver
 
         resolved_tmp_dir = path_resolver(tmp_dir)
@@ -531,7 +527,6 @@ def _named_temporary_file(suffix=None, prefix=None):
         try:
             yield f
         finally:
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()
 
 

tests/spcs/test_services.py

@@ -73,7 +73,6 @@ def enable_events_and_metrics_config():
     from tests.conftest import clean_logging_handlers
 
     with TemporaryDirectory() as tempdir:
-        # Resolve Windows short paths to prevent cleanup issues
         resolved_tempdir = path_resolver(tempdir)
         config_toml = Path(resolved_tempdir) / "config.toml"
         config_toml.write_text(
@@ -84,7 +83,6 @@ def enable_events_and_metrics_config():
         try:
             yield config_toml
         finally:
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()
 
 

tests/test_config.py

@@ -40,7 +40,6 @@ def test_empty_config_file_is_created_if_not_present():
     from tests.conftest import clean_logging_handlers
 
     with TemporaryDirectory() as tmp_dir:
-        # Resolve Windows short paths to prevent cleanup issues
         resolved_tmp_dir = path_resolver(tmp_dir)
         config_file = Path(resolved_tmp_dir) / "sub" / "config.toml"
         assert config_file.exists() is False
@@ -50,7 +49,6 @@ def test_empty_config_file_is_created_if_not_present():
             assert config_file.exists() is True
             assert_file_permissions_are_strict(config_file)
         finally:
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()
 
 
@@ -176,19 +174,16 @@ def test_create_default_config_if_not_exists_with_proper_permissions(
 
     mock_get_config_section.return_value = {}
     with TemporaryDirectory() as tmp_dir:
-        # Resolve Windows short paths to prevent cleanup issues
         resolved_tmp_dir = path_resolver(tmp_dir)
         config_path = Path(f"{resolved_tmp_dir}/snowflake/config.toml")
 
         try:
-            # Test the config initialization with a specific path
             config_init(config_path)
 
             assert config_path.exists()
             assert_file_permissions_are_strict(config_path.parent)
             assert_file_permissions_are_strict(config_path)
         finally:
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()
 
 
@@ -244,7 +239,6 @@ def test_not_found_default_connection_from_evn_variable(test_root_path):
 def test_correct_updates_of_connections_on_setting_default_connection(
     test_snowcli_config, snowflake_home
 ):
-    # Use isolated context for this test to avoid fixture conflicts
     with fork_cli_context() as ctx:
         config = test_snowcli_config
         connections_toml = snowflake_home / "connections.toml"
@@ -261,12 +255,10 @@ def test_correct_updates_of_connections_on_setting_default_connection(
         """
         )
 
-        # Set config file override in isolated context
         ctx.config_file_override = config
-        config_init(None)  # Use context's config file
+        config_init(None)
         set_config_value(path=["default_connection_name"], value="asdf_b")
 
-        # Get config manager from isolated context
         config_manager = ctx.config_manager
 
         def assert_correct_connections_loaded():
@@ -316,16 +308,13 @@ def assert_correct_connections_loaded():
                 config_toml_content.count("dummy_flag = true") == 1
             )  # other settings are not erased
 
-        # reinit config file and recheck loaded connections
-        config_init(None)  # Use context's config file
+        config_init(None)
         assert_correct_connections_loaded()
 
 
 def test_correct_updates_of_connections_on_setting_default_connection_for_empty_config_file(
     config_file, snowflake_home, config_manager
 ):
-    # CONFIG_MANAGER is now accessed through the config_manager fixture
-
     with config_file() as config:
         connections_toml = snowflake_home / "connections.toml"
         connections_toml.write_text(
@@ -390,16 +379,13 @@ def assert_correct_connections_loaded():
                 config_toml_content.count("dummy_flag = true") == 0
             )  # other settings are not erased
 
-        # reinit config file and recheck loaded connections
         config_init(config)
         assert_correct_connections_loaded()
 
 
 def test_connections_toml_override_config_toml(
     test_snowcli_config, snowflake_home, config_manager
 ):
-    # CONFIG_MANAGER is now accessed through the config_manager fixture
-
     connections_toml = snowflake_home / "connections.toml"
     connections_toml.write_text(
         """[default]
@@ -520,7 +506,6 @@ def test_too_wide_permissions_on_custom_config_file_causes_warning_windows(permi
     from tests.conftest import clean_logging_handlers
 
     with TemporaryDirectory() as tmp_dir:
-        # Resolve Windows short paths to prevent cleanup issues
         resolved_tmp_dir = path_resolver(tmp_dir)
         config_path = Path(resolved_tmp_dir) / "config.toml"
         config_path.touch()
@@ -538,7 +523,6 @@ def test_too_wide_permissions_on_custom_config_file_causes_warning_windows(permi
             ):
                 config_init(config_file=config_path)
         finally:
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()
 
 

tests_common/conftest.py

@@ -41,14 +41,12 @@ def temporary_directory():
     initial_dir = os.getcwd()
 
     with tempfile.TemporaryDirectory() as tmp_dir:
-        # Resolve Windows short paths to prevent cleanup issues
         resolved_tmp_dir = path_resolver(tmp_dir)
         try:
             os.chdir(resolved_tmp_dir)
             yield resolved_tmp_dir
         finally:
             os.chdir(initial_dir)
-            # Ensure all logging handlers are closed before temp directory cleanup
             clean_logging_handlers()