feat: [SNOW-2155083] spcs service: support auto-suspend-secs #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added entry for new auto_suspend_secs parameter functionality in SPCS service commands (deploy, set, unset) that allows configuring automatic service suspension after inactivity period.
sfc-gh-jwilkowski
force-pushed
the
jw/SNOW-2155083-auto-suspend-secs-support
branch
from
d7faffb to
6d93b48
Compare
| max_instances = 3 | ||
| query_warehouse = "test_warehouse" | ||
| auto_resume = False | ||
| auto_suspend_secs = 600 |
There was a problem hiding this comment.
Maybe this could be defined instead of magic number?
There was a problem hiding this comment.
None of those matter really, it's just an integer. This variable is local to this test only, I wouldn't see any point in extracting values of service_name, min_instances, max_instances etc either
| @patch(EXECUTE_QUERY) | ||
| def test_set_property_auto_suspend_secs_only(mock_execute_query): | ||
| service_name = "test_service" | ||
| auto_suspend_secs = 300 |
There was a problem hiding this comment.
Here is another magic value. Why not 600 like earlier?
There was a problem hiding this comment.
as above, the exact value doesn't really matter, it just needs to be some positive integer
sfc-gh-mraba
approved these changes
Oct 22, 2025
sfc-gh-jwilkowski
deleted the
jw/SNOW-2155083-auto-suspend-secs-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added entry for new auto_suspend_secs parameter functionality in SPCS service commands (deploy, set, unset) that allows configuring automatic service suspension after inactivity period.
Pre-review checklist
Changes description
https://snowflakecomputing.atlassian.net/browse/SNOW-2155083