add internal and private prefix with _

Author: sfc-gh-erojaslizano

.editorconfig

@@ -17,27 +17,34 @@ max_line_length = 150
 # naming style
 dotnet_naming_style.prefix_and_pascal_case.required_prefix = I
 dotnet_naming_style.prefix_and_pascal_case.capitalization = pascal_case
-
 # naming symbols
 dotnet_naming_symbols.interfaces.applicable_kinds = interface
-
 dotnet_naming_rule.interfaces_begin_with_I.severity = error
 dotnet_naming_rule.interfaces_begin_with_I.symbols = interfaces
 dotnet_naming_rule.interfaces_begin_with_I.style = prefix_and_pascal_case
-
 dotnet_diagnostic.interfaces_begin_with_I.enabled = true
 
 ## Static fields should start with _s
 # naming style
 dotnet_naming_style.prefix_s.required_prefix = _s
 dotnet_naming_style.prefix_s.capitalization = camel_case
-
 # naming symbols
 dotnet_naming_rule.static_fields_begin_with_s.style = prefix_s
 dotnet_naming_symbols.static_fields.applicable_kinds = field
 dotnet_naming_symbols.static_fields.applicable_accessibilities = public, internal, private, protected, protected_internal
 dotnet_naming_symbols.static_fields.required_modifiers = static
-
 dotnet_naming_rule.static_fields_begin_with_s.severity = error
 dotnet_naming_rule.static_fields_begin_with_s.symbols = static_fields
 dotnet_diagnostic.static_fields_begin_with_s.enabled = true
+
+## Internal or private member should prefixed with _
+# naming style
+dotnet_naming_style.internal_prefix_.required_prefix = _
+dotnet_naming_style.internal_prefix_.capitalization = camel_case
+# naming symbols
+dotnet_naming_rule.private_internal_prefix_.style = internal_prefix_
+dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
+dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = internal, private, protected_internal
+dotnet_naming_rule.private_internal_prefix_.severity = error
+dotnet_naming_rule.private_internal_prefix_.symbols = private_internal_fields
+dotnet_diagnostic.private_internal_prefix_.enabled = true

.github/workflows/linter.yml

@@ -13,7 +13,6 @@ on:
       tags:
         description: "Linter"
         required: false
-permissions: { }
 
 concurrency:
   # older builds for the same pull request number or branch should be cancelled
@@ -41,9 +40,6 @@ jobs:
       - name: Add dotnet tools to PATH
         run: echo "$HOME/.dotnet/tools" >> $GITHUB_PATH
 
-    #   - name: Run dotnet restore
-    #     run: dotnet restore
-
       - name: Run Linter Bash Script
         run: |
           bash ci/scripts/linter.sh

Snowflake.Data.Tests/Snowflake.Data.Tests.csproj

@@ -1,9 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net8.0;net6.0;net471;net472</TargetFrameworks>
-    <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net8.0</TargetFrameworks>
-    <RuntimeFrameworkVersion>6.0.0</RuntimeFrameworkVersion>
-    <RuntimeFrameworkVersion Condition="'$(TargetFramework)' == 'net8.0'">8.0.0</RuntimeFrameworkVersion>
+    <TargetFrameworks>net6.0;net7.0;net8.0;net462;net471;net472;net48;net481</TargetFrameworks>
+    <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net7.0;net8.0;</TargetFrameworks>
     <Title>Snowflake.Data.Tests</Title>
     <Description>Snowflake Connector for .NET</Description>
     <Company>Snowflake Computing, Inc</Company>

Snowflake.Data/Core/LinterTestFile.cs

@@ -12,5 +12,6 @@ namespace Snowflake.Data.Core
     public  class LinterTestFile
     {
         private static int nuevoCampo;
+        private int intWithoutPrefix_;
     }
 }

Snowflake.Data/Snowflake.Data.csproj

@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net8.0;net6.0;net471;net472</TargetFrameworks>
-    <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net8.0</TargetFrameworks>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Title>Snowflake.Data</Title>
     <PackageId>Snowflake.Data</PackageId>
     <PackageLicenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</PackageLicenseUrl>
@@ -26,7 +25,7 @@
   <ItemGroup>
     <PackageReference Include="Apache.Arrow" Version="14.0.2" />
     <PackageReference Include="AWSSDK.S3" Version="3.7.0.4" />
-    <PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0" />
+    <PackageReference Include="Google.Cloud.Storage.V1" Version="4.10.0" />
     <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" />
     <PackageReference Include="Azure.Storage.Common" Version="12.12.0" />
     <PackageReference Include="Mono.Unix" Version="7.1.0-final.1.21458.1" />
@@ -37,14 +36,6 @@
     <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'net471' Or '$(TargetFramework)' == 'net472'">
-    <Reference Include="System.Net.Http" />
-  </ItemGroup>
-
-  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
-    <PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" />
-  </ItemGroup>
-
   <ItemGroup Condition="'$(Configuration)' != 'Release'">
     <InternalsVisibleTo Include="Snowflake.Data.Tests" />
     <!--needed by Moq to be able to mock internal interfaces-->