Skip to content

Commit 39dcb03

Browse files
Revert "SNOW-1473274 bump nunit to 4.1.0 (#971)" (#973)
This reverts commit 0e7a4ad. ### Description Reverting switching to newer NUnit since it does not support .netstandard. ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../blob/master/CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
1 parent 0e7a4ad commit 39dcb03

File tree

63 files changed

+15
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+15
-76
lines changed

Snowflake.Data.Tests/IcebergTests/TestIcebergTable.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using Snowflake.Data.Client;
99
using Snowflake.Data.Core;
1010
using Snowflake.Data.Tests.Util;
11-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1211
using static Snowflake.Data.Tests.Util.TestData;
1312

1413
namespace Snowflake.Data.Tests.IcebergTests

Snowflake.Data.Tests/IntegrationTests/EasyLoggingIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using Snowflake.Data.Configuration;
88
using Snowflake.Data.Core;
99
using Snowflake.Data.Log;
10-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1110
using static Snowflake.Data.Tests.UnitTests.Configuration.EasyLoggingConfigGenerator;
1211

1312
namespace Snowflake.Data.Tests.IntegrationTests

Snowflake.Data.Tests/IntegrationTests/FileUploadDownloadLargeFilesIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using NUnit.Framework;
99
using Snowflake.Data.Client;
1010
using Snowflake.Data.Tests.Util;
11-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1211

1312
namespace Snowflake.Data.Tests
1413
{

Snowflake.Data.Tests/IntegrationTests/MaxLobSizeIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using System.Data.Common;
1212
using System.IO;
1313
using System.Linq;
14-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1514

1615
namespace Snowflake.Data.Tests.IntegrationTests
1716
{

Snowflake.Data.Tests/IntegrationTests/SFBindTestIT.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@
1515
using System.Globalization;
1616
using System.Collections.Generic;
1717
using Snowflake.Data.Tests.Util;
18-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1918

2019
namespace Snowflake.Data.Tests.IntegrationTests
2120
{
2221

23-
[TestFixture]
22+
[TestFixture]
2423
class SFBindTestIT : SFBaseTest
2524
{
2625
private static readonly SFLogger s_logger = SFLoggerFactory.GetLogger<SFBindTestIT>();

Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ namespace Snowflake.Data.Tests.IntegrationTests
2020
using Snowflake.Data.Tests.Mock;
2121
using System.Runtime.InteropServices;
2222
using System.Net.Http;
23-
using NUnit.Framework.Legacy;
24-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
2523

2624
[TestFixture]
2725
class SFConnectionIT : SFBaseTest
@@ -801,7 +799,7 @@ public void TestUnknownAuthenticator()
801799
IDbConnection conn = new SnowflakeDbConnection();
802800
conn.ConnectionString = "scheme=http;host=test;port=8080;user=test;password=test;account=test;authenticator=" + wrongAuthenticator;
803801
conn.Open();
804-
Assert.Fail($"Authentication of {wrongAuthenticator} should fail");
802+
Assert.Fail("Authentication of {0} should fail", wrongAuthenticator);
805803
}
806804
catch (SnowflakeDbException e)
807805
{

Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolAsyncIT.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
using System.Threading.Tasks;
1111
using Snowflake.Data.Client;
1212
using Snowflake.Data.Core;
13+
using Snowflake.Data.Log;
1314
using Snowflake.Data.Tests.Mock;
1415
using Moq;
1516
using NUnit.Framework;
16-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1717

1818
namespace Snowflake.Data.Tests.IntegrationTests
1919
{

Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
using Snowflake.Data.Log;
1414
using NUnit.Framework;
1515
using Snowflake.Data.Core.Session;
16-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1716

1817
namespace Snowflake.Data.Tests.IntegrationTests
1918
{

Snowflake.Data.Tests/IntegrationTests/SFDbAdaptorIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ namespace Snowflake.Data.Tests.IntegrationTests
88
using Snowflake.Data.Client;
99
using System.Data;
1010
using System.Runtime.InteropServices;
11-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
1211

1312
[TestFixture]
1413
class SFDbAdaptorIT : SFBaseTest

Snowflake.Data.Tests/IntegrationTests/SFDbCommandIT.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ namespace Snowflake.Data.Tests.IntegrationTests
1818
using System.Globalization;
1919
using Snowflake.Data.Tests.Mock;
2020
using Snowflake.Data.Core;
21-
using Assert = NUnit.Framework.Legacy.ClassicAssert;
2221

2322
[TestFixture]
2423
class SFDbCommandITAsync : SFBaseTestAsync

0 commit comments

Comments
 (0)