Skip to content

Commit 60c2f2b

Browse files
SNOW-1640968 Dispose http response in Okta Authenticator (#1010)
1 parent adac81a commit 60c2f2b

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,7 @@ public void TestOktaConnectionUntilMaxTimeout()
839839
{
840840
TokenUrl = $"{oktaUrl}/api/v1/sessions?additionalFields=cookieToken",
841841
SSOUrl = $"{oktaUrl}/app/testaccount/sso/saml",
842-
ResponseContent = new StringContent("<form=error}"),
842+
ResponseContent = "<form=error}",
843843
MaxRetryCount = expectedMaxRetryCount,
844844
MaxRetryTimeout = expectedMaxConnectionTimeout
845845
};
@@ -2191,7 +2191,7 @@ public void TestAsyncOktaConnectionUntilMaxTimeout()
21912191
{
21922192
TokenUrl = $"{oktaUrl}/api/v1/sessions?additionalFields=cookieToken",
21932193
SSOUrl = $"{oktaUrl}/app/testaccount/sso/saml",
2194-
ResponseContent = new StringContent("<form=error}"),
2194+
ResponseContent = "<form=error}",
21952195
MaxRetryCount = expectedMaxRetryCount,
21962196
MaxRetryTimeout = expectedMaxConnectionTimeout
21972197
};

Snowflake.Data.Tests/Mock/MockOkta.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class MockOktaRestRequester : IMockRestRequester
1515
{
1616
public string TokenUrl { get; set; }
1717
public string SSOUrl { get; set; }
18-
public StringContent ResponseContent { get; set; }
18+
public string ResponseContent { get; set; }
1919
public int MaxRetryCount { get; set; }
2020
public int MaxRetryTimeout { get; set; }
2121

@@ -32,7 +32,7 @@ public Task<T> GetAsync<T>(IRestRequest request, CancellationToken cancellationT
3232
public Task<HttpResponseMessage> GetAsync(IRestRequest request, CancellationToken cancellationToken)
3333
{
3434
var response = new HttpResponseMessage(System.Net.HttpStatusCode.OK);
35-
response.Content = ResponseContent;
35+
response.Content = new StringContent(ResponseContent);
3636
response.Content.Headers.Add(OktaAuthenticator.RetryCountHeader, MaxRetryCount.ToString());
3737
response.Content.Headers.Add(OktaAuthenticator.TimeoutElapsedHeader, MaxRetryTimeout.ToString());
3838
return Task.FromResult(response);

0 commit comments

Comments
 (0)