SNOW-2004510: Fix build warnings (#1124)

Author: sfc-gh-pbulawa

Snowflake.Data.Tests/IntegrationTests/SFBindTestIT.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System;
 using System.Data;
@@ -200,8 +200,8 @@ public void TestBindNullValue(object nullValue)
             }
         }
 
-        private static IEnumerable<object> NullTestCases() =>
-            new object[] { DBNull.Value, null };
+        private static IEnumerable<object?> NullTestCases() =>
+            new object?[] { DBNull.Value, null };
 
         [Test]
         public void TestBindValue()

Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderIT.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using System.Data.Common;
 using System.Data;
@@ -1048,15 +1048,17 @@ public void TestGetStream()
                 {
                     byte[] col1ToBytes = Encoding.UTF8.GetBytes(testChars);
                     byte[] buf = new byte[col1ToBytes.Length];
-                    stream.Read(buf, 0, col1ToBytes.Length);
+                    var readBytes = stream.Read(buf, 0, col1ToBytes.Length);
+                    Assert.AreEqual(col1ToBytes.Length, readBytes);
                     Assert.IsTrue(-1 == stream.ReadByte()); // No more data
                     Assert.IsTrue(col1ToBytes.SequenceEqual(buf));
                 }
 
                 using (var stream = reader.GetStream(1))
                 {
                     byte[] buf = new byte[testBytes.Length];
-                    stream.Read(buf, 0, testBytes.Length);
+                    var readBytes = stream.Read(buf, 0, testBytes.Length);
+                    Assert.AreEqual(testBytes.Length, readBytes);
                     Assert.IsTrue(-1 == stream.ReadByte()); // No more data
                     Assert.IsTrue(testBytes.SequenceEqual(buf));
                 }
@@ -1065,7 +1067,8 @@ public void TestGetStream()
                 {
                     byte[] col3ToBytes = Encoding.UTF8.GetBytes(testDouble.ToString());
                     byte[] buf = new byte[col3ToBytes.Length];
-                    stream.Read(buf, 0, col3ToBytes.Length);
+                    var readBytes = stream.Read(buf, 0, col3ToBytes.Length);
+                    Assert.AreEqual(col3ToBytes.Length, readBytes);
                     Assert.IsTrue(-1 == stream.ReadByte()); // No more data
                     Assert.IsTrue(col3ToBytes.SequenceEqual(buf));
                 }

Snowflake.Data.Tests/IntegrationTests/SFPutGetTest.cs

@@ -794,7 +794,8 @@ private static string[] splitLines(Stream stream)
         {
             var bytes = new byte[stream.Length];
             stream.Position = 0;
-            stream.Read(bytes, 0, (int) stream.Length);
+            var readBytes = stream.Read(bytes, 0, (int) stream.Length);
+            Assert.AreEqual(stream.Length, readBytes);
             return Encoding.UTF8.GetString(bytes).Split('\n');
         }
 

Snowflake.Data.Tests/UnitTests/ConcatenatedStreamTest.cs

@@ -1,4 +1,4 @@
-using Snowflake.Data.Tests.Util;
+using Snowflake.Data.Tests.Util;
 using NUnit.Framework;
 using System;
 using System.IO;
@@ -109,7 +109,7 @@ public void TestReadMoreBytesThanBufferSize()
             try
             {
                 // An ArgumentException is thrown when 4 bytes is read from a buffer of size 3
-                _concatStream.Read(buffer, 0, 4);
+                var readBytes = _concatStream.Read(buffer, 0, 4);
                 Assert.Fail("An ArgumentException should've been thrown");
             }
             catch (Exception ex)