SNOW-2359496 Add additional ways to infer the default AWS Region (#1266)

Co-authored-by: Timo Vink <[email protected]>

Author: sfc-gh-mgemra

CHANGELOG.md

@@ -4,6 +4,7 @@
 - v5.1.0
     - Added `APPLICATION_PATH` to `CLIENT_ENVIRONMENT` sent during authentication to identify the application connecting to Snowflake.
     - Renew idle sessions in the pool if keep alive is enabled.
+    - AWS WIF will now also check the application config and AWS profile credential store when determining the current AWS region
 - v5.0.0
     - Disabled CRL checks by default.
     - Added support for alternative, memory efficient and thread safe CRL (Certificate Revocation List) checks.

Snowflake.Data/Core/Authenticator/WorkflowIdentity/AwsSdkWrapper.cs

@@ -10,6 +10,6 @@ public virtual ImmutableCredentials GetAwsCredentials() =>
             FallbackCredentialsFactory.GetCredentials()?.GetCredentials();
 
         public virtual string GetAwsRegion() =>
-            Amazon.Util.EC2InstanceMetadata.Region?.SystemName;
+            FallbackRegionFactory.GetRegionEndpoint()?.SystemName;
     }
 }

Snowflake.Data/Core/Authenticator/WorkflowIdentity/WorkflowIdentityAwsAttestationRetriever.cs

@@ -88,11 +88,6 @@ private ImmutableCredentials GetAwsCredentials()
 
         private string GetAwsRegion()
         {
-            var regionFromEnv = _environmentOperations.GetEnvironmentVariable("AWS_REGION");
-            if (!string.IsNullOrEmpty(regionFromEnv))
-            {
-                return regionFromEnv;
-            }
             var region = _awsSdkWrapper.GetAwsRegion();
             if (string.IsNullOrEmpty(region))
             {