-
Notifications
You must be signed in to change notification settings - Fork 151
Open
Labels
featurestatus-pr_pending_mergeA PR is made and is under reviewA PR is made and is under reviewstatus-triage_doneInitial triage done, will be further handled by the driver teamInitial triage done, will be further handled by the driver team
Description
What is the current behavior?
The current HttpUtil implementation allows 2 scenarios:
- Explicitly set proxy by specifying
useproxy,proxyhost... in the connection string - Ignore proxy parameters in which case a proxy will never be used
This does not allow the default proxy scenarios, for instance:
- Getting proxy configuration from environment variables (
HTTP_PROXY,HTTPS_PROXY,NO_PROXY...) - On Windows, getting proxy configuration from WinInet, which is the only scenario supporting PAC scripts AFAIK
What is the desired behavior?
Since HttpClientHandler.UseProxy defaults to true and not specifying HttpClientHandler.Proxy will use the default proxy by default:
- If
useproxyis true and proxy parameters are specified (proxyhost...) setHttpClientHandler.Proxy--> already available - If
useproxyis false, setHttpClientHandler.UseProxyto false --> already available - If
useproxyis true and no proxy parameters are specified (proxyhost...) leaveHttpClientHandler.Proxyto its default value --> not available today
How would this improve snowflake-connector-net?
This would allow proxy settings from environment variables, PAC scripts... to be used to connect to Snowflake.
References, Other Background
Metadata
Metadata
Assignees
Labels
featurestatus-pr_pending_mergeA PR is made and is under reviewA PR is made and is under reviewstatus-triage_doneInitial triage done, will be further handled by the driver teamInitial triage done, will be further handled by the driver team