-
Notifications
You must be signed in to change notification settings - Fork 151
SNOW-2026116 Remove Mono.Unix from Windows dependencies #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sfc-gh-mgemra
wants to merge
8
commits into
master
Choose a base branch
from
mgemra/SNOW-2026116-remove-mono-unix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+458
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the full list of 3 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
8239867 to
cc1d724
Compare
7797a1b to
13601c4
Compare
13601c4 to
e187b82
Compare
baa0c1b to
86de02e
Compare
- Created DirectoryOperationsWindowsTest for Windows-specific tests - Created DirectoryOperationsUnixTest for Unix-specific tests - Added RuntimeInformation platform check in Unix test setup - Added [Platform(Exclude="Win")] to DirectoryUnixInformationTest - Removed original mixed DirectoryOperationsTest file This completes the platform-specific test refactoring to fix OneTimeSetUp errors on Windows for net481 target framework.
3bb6644 to
3298127
Compare
The converter was double-counting permissions by including both individual flags (UserRead, UserWrite) and their combinations (UserReadWrite). This caused it to return incorrect values, e.g. expecting 404 but getting 1004. The fix excludes all combination flags (ReadWrite, ReadExecute, WriteExecute, AllPermissions, DefaultPermissions, None) so only individual Read/Write/Execute flags are counted. All 512 UnixFilePermissionsConverterTest test cases now pass.
095f338 to
5faeee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Package will not contain dll dedicated to a given OS and platform:
Versions dedicated for Windows do not contain Mono.Unix dependency.
You can verify it by building a package and then veryfing
nuspecfile, e.g:unzip -p Snowflake.Data.5.1.0.nupkg Snowflake.Data.nuspec | grep -A 15 "targetFramework=\"net8.0\""The size of the package increased (multiple dlls), but IMO it's still small and acceptable (still under 1 MB).
More about targetting and precedence is described here: https://github.com/dotnet/designs/blob/main/accepted/2020/net5/net5.md#precedences - tldr; The assets that are closer in version number are chosen over platform-specific assets.
Checklist
dotnet test)