-
Notifications
You must be signed in to change notification settings - Fork 151
Update README.md (small typos) #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| where: | ||
|
|
||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the unencrypted private key. | ||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the encrypted private key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is below an example showing it is not encrypted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'm not sure what example you mean.
The section just below this line does use an unencrypted key, but this line seems to be about the example just above ("Specify the file containing an encrypted private key").
Also, why would you need to also provide the private_key_pwd if the private key were not encrypted?
Let me know if I'm missing something.
| where: | ||
|
|
||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the unencrypted private key. | ||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the encrypted private key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mweeden2
I think the same was spot here:
https://github.com/snowflakedb/snowflake-connector-net/pull/1053/files
Is this clear in this way?
I fixed two typos in the README.