Skip to content

Conversation

@mweeden2
Copy link

@mweeden2 mweeden2 commented Apr 5, 2024

I fixed two typos in the README.

@mweeden2 mweeden2 requested a review from a team as a code owner April 5, 2024 18:54
@github-actions
Copy link

github-actions bot commented Apr 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mweeden2
Copy link
Author

mweeden2 commented Apr 5, 2024

I have read the CLA Document and I hereby sign the CLA

where:

- `{pathToThePrivateKeyFile}` is the path to the file containing the unencrypted private key.
- `{pathToThePrivateKeyFile}` is the path to the file containing the encrypted private key.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is below an example showing it is not encrypted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'm not sure what example you mean.

The section just below this line does use an unencrypted key, but this line seems to be about the example just above ("Specify the file containing an encrypted private key").

Also, why would you need to also provide the private_key_pwd if the private key were not encrypted?

Let me know if I'm missing something.

where:

- `{pathToThePrivateKeyFile}` is the path to the file containing the unencrypted private key.
- `{pathToThePrivateKeyFile}` is the path to the file containing the encrypted private key.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweeden2
I think the same was spot here:
https://github.com/snowflakedb/snowflake-connector-net/pull/1053/files
Is this clear in this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants