SNOW-26262: bypassed numeric value conversions for SnowSQL to improve performance.

Author: smtakeda

connection.py

@@ -214,6 +214,13 @@ def errorhandler(self):
         """
         return self._errorhandler
 
+    @property
+    def converter_class(self):
+        """
+        Converter Class
+        """
+        return self._converter_class
+
     @errorhandler.setter
     def errorhandler(self, value):
         if value is None:

converter.py

@@ -10,8 +10,7 @@
 
 import pytz
 
-from .compat import (IS_UNICODE, IS_BYTES, IS_BINARY, TO_UNICODE, IS_NUMERIC)
-from .constants import (UTF8)
+from .compat import (IS_BINARY, TO_UNICODE, IS_NUMERIC)
 from .errorcode import (ER_NOT_SUPPORT_DATA_TYPE)
 from .errors import (ProgrammingError)
 from .sfbinaryformat import (binary_to_python,
@@ -335,11 +334,7 @@ def _TIME_to_python(self, value, col_desc, *_):
     _TIME_numpy_to_python = _TIME_to_python
 
     def _VARIANT_to_python(self, value, *_):
-        if IS_UNICODE(value):
-            return value
-        elif IS_BYTES(value):
-            return value.decode(UTF8)
-        return TO_UNICODE(value)
+        return value
 
     _VARIANT_numpy_to_python = _VARIANT_to_python
 
@@ -359,7 +354,7 @@ def _BOOLEAN_to_python(self, value, *_):
     _BOOLEAN_numpy_to_python = _BOOLEAN_to_python
 
     #
-    # TO Snowflake
+    # From Python to Snowflake
     #
     def to_snowflake(self, value):
         type_name = value.__class__.__name__.lower()

converter_snowsql.py

@@ -66,6 +66,12 @@ def to_python_method(self, type_name, row_type):
             # no type is defined, pass through it
             return self._TEXT_to_python, None
 
+    def _BOOLEAN_to_python(self, value, *_):
+        """
+        No conversion for SnowSQL
+        """
+        return u"True" if value in (u'1', u"True") else u"False"
+
     def _FIXED_to_python(self, value, *_):
         """
         No conversion for SnowSQL

file_transfer_agent.py

@@ -5,18 +5,20 @@
 #
 import glob
 import mimetypes
+import os
+import shutil
 import sys
+import tempfile
 import threading
 from logging import getLogger
 from multiprocessing.pool import ThreadPool
 from time import (time, sleep)
 
 import botocore.exceptions
-import os
-import shutil
-import tempfile
+
 from .compat import (GET_CWD, TO_UNICODE)
 from .constants import (SHA256_DIGEST)
+from .converter_snowsql import SnowflakeConverterSnowSQL
 from .errorcode import (ER_INVALID_STAGE_FS, ER_INVALID_STAGE_LOCATION,
                         ER_LOCAL_PATH_NOT_DIRECTORY,
                         ER_FILE_NOT_EXISTS,
@@ -510,6 +512,7 @@ def renew_expired_aws_token(self):
             use_accelerate_endpoint=self._use_accelerate_endpoint)
 
     def result(self):
+        converter_class = self._cursor._connection.converter_class
         rowset = []
         if self._command_type == CMD_TYPE_UPLOAD:
             if hasattr(self, u'_results'):
@@ -531,11 +534,19 @@ def result(self):
                     else:
                         error_details = u''
 
+                    src_file_size = meta[u'src_file_size'] \
+                        if converter_class != SnowflakeConverterSnowSQL \
+                        else TO_UNICODE(meta[u'src_file_size'])
+
+                    dst_file_size = meta[u'dst_file_size'] \
+                        if converter_class != SnowflakeConverterSnowSQL \
+                        else TO_UNICODE(meta[u'dst_file_size'])
+
                     rowset.append([
                         meta[u'name'],
                         meta[u'dst_file_name'],
-                        meta[u'src_file_size'],
-                        meta[u'dst_file_size'],
+                        src_file_size,
+                        dst_file_size,
                         src_compression_type,
                         dst_compression_type,
                         meta[u'result_status'],
@@ -557,13 +568,17 @@ def result(self):
         else:  # DOWNLOAD
             if hasattr(self, u'_results'):
                 for meta in self._results:
+                    dst_file_size = meta[u'dst_file_size'] \
+                        if converter_class != SnowflakeConverterSnowSQL \
+                        else TO_UNICODE(meta[u'dst_file_size'])
+
                     if u'error_details' in meta:
                         error_details = meta[u'error_details']
                     else:
                         error_details = u''
                     rowset.append([
                         meta[u'dst_file_name'],
-                        meta[u'dst_file_size'],
+                        dst_file_size,
                         meta[u'result_status'],
                         error_details
                     ])