SNOW-80651 renamed SnowflakeConnection.safe_to_destroy to something less confusi… (#553)

Author: sfc-gh-mkeller

src/snowflake/connector/connection.py

@@ -437,7 +437,7 @@ def close(self, retry=True):
             # close telemetry first, since it needs rest to send remaining data
             logger.info('closed')
             self._telemetry.close(send_on_close=retry)
-            if self.safe_to_close():
+            if self._all_async_queries_finished():
                 logger.info('No async queries seem to be running, deleting session')
                 self.rest.delete_session(retry=retry)
             else:
@@ -1231,11 +1231,8 @@ def is_an_error(status: QueryStatus) -> bool:
             QueryStatus.BLOCKED,
         )
 
-    def safe_to_close(self) -> bool:
-        """Checks whether this connection is safe to close.
-
-        A connection is safe to close if all of its async queries are not running anymore.
-        """
+    def _all_async_queries_finished(self) -> bool:
+        """Checks whether all async queries started by this Connection have finished executing."""
         queries = copy.copy(self._async_sfqids)  # get_query_status might update _async_sfqids, let's copy the list
         finished_async_queries = (not self.is_still_running(self.get_query_status(q)) for q in queries)
         return all(finished_async_queries)

test/integ/test_async.py

@@ -134,7 +134,7 @@ def test_done_caching(conn_cnx):
             assert con.get_query_status(qid2) == QueryStatus.SUCCESS
             assert len(con._async_sfqids) == 0
             assert len(con._done_async_sfqids) == 2
-            assert con.safe_to_close()
+            assert con._all_async_queries_finished()
 
 
 def test_invalid_uuid_get_status(conn_cnx):