Revert "SNOW-676736: get file results in change of file permissions does not inherit parent folder permission (#1338)"

This reverts commit 0cc95b3.

Author: sfc-gh-mkeller

DESCRIPTION.md

@@ -10,7 +10,6 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
 
 - v2.8.3(Unreleased)
   - Bumped cryptography dependency from <39.0.0 to <41.0.0
-  - Fixed a bug where the permission of the file downloaded via GET command is changed
   - Fixed a bug where expired OCSP response cache caused infinite recursion during cache loading
 
 - v2.8.2(November 18,2022)

src/snowflake/connector/encryption_util.py

@@ -18,7 +18,6 @@
 
 from .compat import PKCS5_OFFSET, PKCS5_PAD, PKCS5_UNPAD
 from .constants import UTF8, EncryptionMetadata, MaterialDescriptor, kilobyte
-from .util_text import random_string
 
 block_size = int(algorithms.AES.block_size / 8)  # in bytes
 
@@ -239,13 +238,12 @@ def decrypt_file(
         Returns:
             The decrypted file's location.
         """
-        temp_output_file = f"{os.path.basename(in_filename)}#{random_string()}"
-        if tmp_dir:
-            temp_output_file = os.path.join(tmp_dir, temp_output_file)
-
+        temp_output_fd, temp_output_file = tempfile.mkstemp(
+            text=False, dir=tmp_dir, prefix=os.path.basename(in_filename) + "#"
+        )
         logger.debug("encrypted file: %s, tmp file: %s", in_filename, temp_output_file)
         with open(in_filename, "rb") as infile:
-            with open(temp_output_file, "wb") as outfile:
+            with os.fdopen(temp_output_fd, "wb") as outfile:
                 SnowflakeEncryptionUtil.decrypt_stream(
                     metadata, encryption_material, infile, outfile, chunk_size
                 )

test/integ/test_put_get.py

@@ -671,27 +671,3 @@ def test_get_empty_file(tmp_path, conn_cnx):
             with pytest.raises(OperationalError, match=".*the file does not exist.*$"):
                 cur.execute(f"GET @{stage_name}/foo.csv file://{tmp_path}")
             assert not empty_file.exists()
-
-
-@pytest.mark.skipolddriver
-def test_get_file_permission(tmp_path, conn_cnx):
-    test_file = tmp_path / "data.csv"
-    test_file.write_text("1,2,3\n")
-    stage_name = random_string(5, "test_get_empty_file_")
-    with conn_cnx() as cnx:
-        with cnx.cursor() as cur:
-            cur.execute(f"create temporary stage {stage_name}")
-            filename_in_put = str(test_file).replace("\\", "/")
-            cur.execute(
-                f"PUT 'file://{filename_in_put}' @{stage_name}",
-            )
-
-            cur.execute(f"GET @{stage_name}/data.csv file://{tmp_path}")
-            # get the default mask, usually it is 0o022
-            default_mask = os.umask(0)
-            os.umask(default_mask)
-            # files by default are given the permission 644 (Octal)
-            # umask is for denial, we need to negate
-            assert (
-                oct(os.stat(test_file).st_mode)[-3:] == oct(0o666 & ~default_mask)[-3:]
-            )