testing dynamic port allocation

Author: sfc-gh-pcyrek

test/conftest.py

@@ -2,10 +2,11 @@
 from __future__ import annotations
 
 import os
+import socket
 from contextlib import contextmanager
 from logging import getLogger
 from pathlib import Path
-from typing import Generator
+from typing import Generator, Optional
 
 import pytest
 
@@ -148,3 +149,23 @@ def pytest_runtest_setup(item) -> None:
     if "auth" in test_tags:
         if os.getenv("RUN_AUTH_TESTS") != "true":
             pytest.skip("Skipping auth test in current environment")
+
+
+def find_free_port() -> int:
+    """Find a free port to avoid conflicts in parallel test environments."""
+    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
+        s.bind(("", 0))
+        s.listen(1)
+        port = s.getsockname()[1]
+    return port
+
+
+def get_server_parameter_value(connection, parameter_name: str) -> Optional[str]:
+    """Get server parameter value, returns None if parameter doesn't exist."""
+    try:
+        with connection.cursor() as cur:
+            cur.execute(f"show parameters like '{parameter_name}'")
+            ret = cur.fetchone()
+            return ret[1] if ret else None
+    except Exception:
+        return None

test/integ/test_connection.py

@@ -111,6 +111,8 @@ def test_connection_without_database2(db_parameters):
 
 def test_with_config(db_parameters):
     """Creates a connection with the config parameter."""
+    from ..conftest import get_server_parameter_value
+
     config = {
         "user": db_parameters["user"],
         "password": db_parameters["password"],
@@ -125,7 +127,22 @@ def test_with_config(db_parameters):
     cnx = snowflake.connector.connect(**config)
     try:
         assert cnx, "invalid cnx"
-        assert not cnx.client_session_keep_alive  # default is False
+
+        # Check what the server default is to make test environment-aware
+        server_default_str = get_server_parameter_value(
+            cnx, "CLIENT_SESSION_KEEP_ALIVE"
+        )
+        if server_default_str:
+            server_default = server_default_str.lower() == "true"
+            # Test that connection respects server default when not explicitly set
+            assert (
+                cnx.client_session_keep_alive == server_default
+            ), f"Expected client_session_keep_alive={server_default} (server default), got {cnx.client_session_keep_alive}"
+        else:
+            # Fallback: if we can't determine server default, expect False
+            assert (
+                not cnx.client_session_keep_alive
+            ), "Expected client_session_keep_alive=False when server default unknown"
     finally:
         cnx.close()
 

test/unit/test_oauth_token.py

@@ -376,6 +376,8 @@ def test_oauth_code_local_application_custom_urls_successful_flow(
     monkeypatch,
     omit_oauth_urls_check,
 ) -> None:
+    from ..conftest import find_free_port
+
     monkeypatch.setenv("SNOWFLAKE_AUTH_SOCKET_REUSE_PORT", "true")
 
     wiremock_client.import_mapping(
@@ -389,6 +391,10 @@ def test_oauth_code_local_application_custom_urls_successful_flow(
         wiremock_generic_mappings_dir / "snowflake_disconnect_successful.json"
     )
 
+    # Use dynamic port to avoid conflicts and higher timeout for all environments
+    free_port = find_free_port()
+    oauth_redirect_uri = f"http://localhost:{free_port}/snowflake/oauth-redirect"
+
     with mock.patch("webbrowser.open", new=webbrowser_mock.open):
         with mock.patch("secrets.token_urlsafe", return_value="abc123"):
             cnx = snowflake.connector.connect(
@@ -401,9 +407,10 @@ def test_oauth_code_local_application_custom_urls_successful_flow(
                 role="ANALYST",
                 oauth_token_request_url=f"http://{wiremock_client.wiremock_host}:{wiremock_client.wiremock_http_port}/tokenrequest",
                 oauth_authorization_url=f"http://{wiremock_client.wiremock_host}:{wiremock_client.wiremock_http_port}/authorization",
-                oauth_redirect_uri="http://localhost:8009/snowflake/oauth-redirect",
+                oauth_redirect_uri=oauth_redirect_uri,
                 host=wiremock_client.wiremock_host,
                 port=wiremock_client.wiremock_http_port,
+                external_browser_timeout=120,  # Higher timeout for all environments
             )
 
             assert cnx, "invalid cnx"