SNOW-2043523: Isabs fix

Author: sfc-gh-fpawlowski

src/snowflake/connector/file_transfer_agent.py

@@ -14,6 +14,8 @@
 from logging import getLogger
 from time import time
 from typing import IO, TYPE_CHECKING, Any, Callable, TypeVar
+from urllib.parse import urlparse
+from urllib.request import url2pathname
 
 from .azure_storage_client import SnowflakeAzureRestClient
 from .compat import GET_CWD, IS_WINDOWS
@@ -837,10 +839,13 @@ def result(self) -> dict[str, Any]:
     def _expand_filenames(self, locations: list[str]) -> list[str]:
         canonical_locations = []
         for file_name in locations:
+            # TODO: Since python 3.13 os.path.isabs returns other values for URI ... comment to be finished
+            parsed = urlparse(file_name)
+            if parsed.scheme == "file":
+                file_name = url2pathname(parsed.path)
+
             if self._command_type == CMD_TYPE_UPLOAD:
                 file_name = os.path.expanduser(file_name)
-                if not os.path.isabs(file_name):
-                    file_name = os.path.join(GET_CWD(), file_name)
                 if (
                     IS_WINDOWS
                     and len(file_name) > 2
@@ -850,6 +855,10 @@ def _expand_filenames(self, locations: list[str]) -> list[str]:
                     # Windows path: /C:/data/file1.txt where it starts with slash
                     # followed by a drive letter and colon.
                     file_name = file_name[1:]
+
+                if not os.path.isabs(file_name):
+                    file_name = os.path.join(GET_CWD(), file_name)
+
                 files = glob.glob(file_name)
                 canonical_locations += files
             else:

src/snowflake/connector/log_configuration.py

@@ -26,6 +26,8 @@ def parse_config_file(self):
             self.level = log.get("level", "INFO")
             self.path = log.get("path", os.path.join(DIRS.user_config_path, "logs"))
 
+            # TODO: wont work in 3.13?
+            # if not self.path.scheme and self.path.netloc and self.path.path.startswith("/"):
             if not os.path.isabs(self.path):
                 raise FileNotFoundError(
                     f"Log path must be an absolute file path: {self.path}"

test/integ/test_put_windows_path.py

@@ -14,7 +14,6 @@ def test_abc(conn_cnx, tmpdir, db_parameters):
         f.write("test1,test2")
         f.write("test3,test4")
 
-    assert os.path.exists(tmp_dir), f"Temporary directory {tmp_dir} does not exist."
     assert os.path.exists(test_data), f"Test data {test_data} does not exist."
 
     fileURI = pathlib.Path(test_data).as_uri()