SNOW-1473581: Fix SSO url validator for nested urls (#1974)

Author: sfc-gh-yixie

DESCRIPTION.md

@@ -17,6 +17,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
   - Fixed a bug that status code shown as uploaded when PUT command failed with 400 error.
   - Fixed a bug that a PermissionError was raised when the current user does not have the right permission on parent directory of config file path.
   - Fixed a bug that OCSP GET url is not encoded correctly when it contains a slash.
+  - Fixed a bug that an SSO URL didn't accept `:` in a query parameter, for instance, `https://sso.abc.com/idp/startSSO.ping?PartnerSpId=https://xyz.snowflakecomputing.com/`.
 
 - v3.10.1(May 21, 2024)
 

src/snowflake/connector/url_util.py

@@ -12,7 +12,7 @@
 
 
 URL_VALIDATOR = re.compile(
-    "^http(s?)\\:\\/\\/[0-9a-zA-Z]([-.\\w]*[0-9a-zA-Z@:])*(:(0-9)*)*(\\/?)([a-zA-Z0-9\\-\\.\\?\\,\\&\\(\\)\\/\\\\\\+&%\\$#_=@]*)?$"
+    "^http(s?)\\:\\/\\/[0-9a-zA-Z]([-.\\w]*[0-9a-zA-Z@:])*(:(0-9)*)*(\\/?)([a-zA-Z0-9\\-\\.\\?\\,\\&\\(\\)\\/\\\\\\+&%\\$#_=@:]*)?$"
 )
 
 

test/unit/test_url_util.py

@@ -17,6 +17,9 @@ def test_url_validator():
     assert is_valid_url("https://ssoTestURL.okta.com")
     assert is_valid_url("https://ssoTestURL.okta.com:8080")
     assert is_valid_url("https://ssoTestURL.okta.com/testpathvalue")
+    assert is_valid_url(
+        "https://sso.abc.com/idp/startSSO.ping?PartnerSpId=https://xyz.eu-central-1.snowflakecomputing.com/"
+    )
 
     assert not is_valid_url("-a Calculator")
     assert not is_valid_url("This is a random text")