SNOW-1572306: error experience in asyncio (#2082)

Author: sfc-gh-aling

src/snowflake/connector/aio/_connection.py

@@ -653,16 +653,30 @@ def auth_class(self, value: AuthByPlugin) -> None:
 
     @property
     def client_prefetch_threads(self) -> int:
-        # TODO: use client_prefetch_threads as numbers for coroutines? how to communicate to users
-        logger.warning("asyncio does not support client_prefetch_threads")
         return self._client_prefetch_threads
 
     @client_prefetch_threads.setter
     def client_prefetch_threads(self, value) -> None:
-        # TODO: use client_prefetch_threads as numbers for coroutines? how to communicate to users
-        logger.warning("asyncio does not support client_prefetch_threads")
         self._client_prefetch_threads = value
 
+    @property
+    def errorhandler(self) -> None:
+        # check SNOW-1763103
+        raise NotImplementedError(
+            "Async Snowflake Python Connector does not support errorhandler. "
+            "Please open a feature request issue in github if your want this feature: "
+            "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose."
+        )
+
+    @errorhandler.setter
+    def errorhandler(self, value) -> None:
+        # check SNOW-1763103
+        raise NotImplementedError(
+            "Async Snowflake Python Connector does not support errorhandler. "
+            "Please open a feature request issue in github if your want this feature: "
+            "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose."
+        )
+
     @property
     def rest(self) -> SnowflakeRestful | None:
         return self._rest

src/snowflake/connector/aio/_cursor.py

@@ -826,6 +826,24 @@ async def execute_async(self, *args: Any, **kwargs: Any) -> dict[str, Any]:
         kwargs["_exec_async"] = True
         return await self.execute(*args, **kwargs)
 
+    @property
+    def errorhandler(self):
+        # check SNOW-1763103
+        raise NotImplementedError(
+            "Async Snowflake Python Connector does not support errorhandler. "
+            "Please open a feature request issue in github if your want this feature: "
+            "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose."
+        )
+
+    @errorhandler.setter
+    def errorhandler(self, value):
+        # check SNOW-1763103
+        raise NotImplementedError(
+            "Async Snowflake Python Connector does not support errorhandler. "
+            "Please open a feature request issue in github if your want this feature: "
+            "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose."
+        )
+
     async def describe(self, *args: Any, **kwargs: Any) -> list[ResultMetadata]:
         """Obtain the schema of the result without executing the query.
 

src/snowflake/connector/aio/_network.py

@@ -18,15 +18,7 @@
 import OpenSSL.SSL
 from urllib3.util.url import parse_url
 
-from ..compat import (
-    FORBIDDEN,
-    OK,
-    UNAUTHORIZED,
-    BadStatusLine,
-    IncompleteRead,
-    urlencode,
-    urlparse,
-)
+from ..compat import FORBIDDEN, OK, UNAUTHORIZED, urlencode, urlparse
 from ..constants import (
     _CONNECTIVITY_ERR_MSG,
     HTTP_HEADER_ACCEPT,
@@ -798,7 +790,7 @@ async def _request_exec(
                     return None  # required for tests
             finally:
                 raw_ret.close()  # ensure response is closed
-        except aiohttp.ClientSSLError as se:
+        except (aiohttp.ClientSSLError, aiohttp.ClientConnectorSSLError) as se:
             msg = f"Hit non-retryable SSL error, {str(se)}.\n{_CONNECTIVITY_ERR_MSG}"
             logger.debug(msg)
             # the following code is for backward compatibility with old versions of python connector which calls
@@ -812,15 +804,11 @@ async def _request_exec(
                     "errno": ER_FAILED_TO_REQUEST,
                 },
             )
-        # TODO: sync feature parity, aiohttp network error handling
         except (
-            BadStatusLine,
-            ConnectionError,
             aiohttp.ClientConnectionError,
-            aiohttp.ClientPayloadError,
-            aiohttp.ClientResponseError,
+            aiohttp.ClientConnectorError,
+            aiohttp.ConnectionTimeoutError,
             asyncio.TimeoutError,
-            IncompleteRead,
             OpenSSL.SSL.SysCallError,
             KeyError,  # SNOW-39175: asn1crypto.keys.PublicKeyInfo
             ValueError,
@@ -845,7 +833,15 @@ async def _request_exec(
                 )
                 raise RetryRequest(err)
         except Exception as err:
-            raise err
+            if isinstance(err, (Error, RetryRequest, ReauthenticationRequest)):
+                raise err
+            raise OperationalError(
+                msg=f"Unexpected error occurred during request execution: {err}"
+                "Please check the stack trace for more information and retry the operation."
+                "If you think this is a bug, please collect the error information and open a bug report in github: "
+                "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose.",
+                errno=ER_FAILED_TO_REQUEST,
+            ) from err
 
     def make_requests_session(self) -> aiohttp.ClientSession:
         s = aiohttp.ClientSession(

src/snowflake/connector/errors.py

@@ -336,10 +336,18 @@ def hand_to_other_handler(
             connection.messages.append((error_class, error_value))
         if cursor is not None:
             cursor.messages.append((error_class, error_value))
-            cursor.errorhandler(connection, cursor, error_class, error_value)
+            try:
+                cursor.errorhandler(connection, cursor, error_class, error_value)
+            except NotImplementedError:
+                # for async compatibility, check SNOW-1763096 and SNOW-1763103
+                cursor._errorhandler(connection, cursor, error_class, error_value)
             return True
         elif connection is not None:
-            connection.errorhandler(connection, cursor, error_class, error_value)
+            try:
+                connection.errorhandler(connection, cursor, error_class, error_value)
+            except NotImplementedError:
+                # for async compatibility, check SNOW-1763096 and SNOW-1763103
+                connection._errorhandler(connection, cursor, error_class, error_value)
             return True
         return False
 

test/integ/aio/test_connection_async.py

@@ -998,6 +998,7 @@ async def test_region_deprecation(conn_cnx):
         assert "Region has been deprecated" in str(w[0].message)
 
 
+@pytest.mark.skip("SNOW-1763103")
 async def test_invalid_errorhander_error(conn_cnx):
     """Tests if no errorhandler cannot be set."""
     async with conn_cnx() as conn:

test/integ/aio/test_cursor_async.py

@@ -984,12 +984,14 @@ async def test_real_decimal(conn, db_parameters):
             assert rec["RATIO"] == decimal.Decimal("23.4"), "the decimal value"
 
 
+@pytest.mark.skip("SNOW-1763103")
 async def test_none_errorhandler(conn_testaccount):
     c = conn_testaccount.cursor()
     with pytest.raises(errors.ProgrammingError):
         c.errorhandler = None
 
 
+@pytest.mark.skip("SNOW-1763103")
 async def test_nope_errorhandler(conn_testaccount):
     def user_errorhandler(connection, cursor, errorclass, errorvalue):
         pass

test/unit/aio/test_retry_network_async.py

@@ -30,8 +30,6 @@
     OK,
     SERVICE_UNAVAILABLE,
     UNAUTHORIZED,
-    BadStatusLine,
-    IncompleteRead,
 )
 from snowflake.connector.errors import (
     DatabaseError,
@@ -232,16 +230,11 @@ async def test_request_exec():
     with pytest.raises(ForbiddenError):
         await rest._request_exec(session=session, **login_parameters)
 
-    class IncompleteReadMock(IncompleteRead):
-        def __init__(self):
-            IncompleteRead.__init__(self, "")
-
     # handle retryable exception
     for exc in [
         aiohttp.ConnectionTimeoutError,
         aiohttp.ClientConnectorError(MagicMock(), OSError(1)),
         asyncio.TimeoutError,
-        IncompleteReadMock,
         AttributeError,
     ]:
         session = AsyncMock()
@@ -264,7 +257,6 @@ def __init__(self):
         OpenSSL.SSL.SysCallError(errno.ETIMEDOUT),
         OpenSSL.SSL.SysCallError(errno.EPIPE),
         OpenSSL.SSL.SysCallError(-1),  # unknown
-        BadStatusLine("fake"),
     ]:
         session = AsyncMock()
         session.request = Mock(side_effect=exc)